Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8010

Avoid sql_alloc() in Items

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.7
    • OTHER
    • None

    Description

      sql_alloc() has additional costs compared to direct mem_root allocation:

      • function call: it is defined in a separate translation unit and can't be inlined
      • it needs to call pthread_getspecific() to get THD::mem_root

      It is called dozens of times implicitly by Items. Try to get rid of those calls.

      Attachments

        1. mdev8010.patch
          653 kB
          Sergey Vojtovich

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-6152 Remove calls to current_thd while creating Item

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link Github revision

          Activity

            Ascending order - Click to sort in descending order
            svoj Sergey Vojtovich created issue -
            svoj Sergey Vojtovich made changes -
            Field Original Value New Value
            Epic Link MDEV-7941 [ 50796 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Workflow MariaDB v2 [ 60572 ] MariaDB v3 [ 65277 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergey Vojtovich [ svoj ]
            svoj Sergey Vojtovich made changes -
            svoj Sergey Vojtovich made changes -
            Attachment mdev8010.patch [ 39101 ]
            svoj Sergey Vojtovich made changes -
            Assignee Sergey Vojtovich [ svoj ] Michael Widenius [ monty ]
            Status Open [ 1 ] In Review [ 10002 ]
            monty Michael Widenius made changes -
            Assignee Michael Widenius [ monty ] Sergey Vojtovich [ svoj ]
            elenst Elena Stepanova made changes -
            Assignee Sergey Vojtovich [ svoj ] Elena Stepanova [ elenst ]
            monty Michael Widenius made changes -
            Assignee Elena Stepanova [ elenst ] Michael Widenius [ monty ]
            monty Michael Widenius made changes -
            Status In Review [ 10002 ] Stalled [ 10000 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.1.7-2 [ 12 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked higher
            svoj Sergey Vojtovich made changes -
            Assignee Michael Widenius [ monty ] Sergey Vojtovich [ svoj ]
            svoj Sergey Vojtovich made changes -
            svoj Sergey Vojtovich made changes -
            Component/s OTHER [ 10125 ]
            Fix Version/s 10.1.7 [ 19604 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 65277 ] MariaDB v4 [ 132595 ]

            People

              svoj Sergey Vojtovich
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.