Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8010

Avoid sql_alloc() in Items

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.7
    • OTHER
    • None

    Description

      sql_alloc() has additional costs compared to direct mem_root allocation:

      • function call: it is defined in a separate translation unit and can't be inlined
      • it needs to call pthread_getspecific() to get THD::mem_root

      It is called dozens of times implicitly by Items. Try to get rid of those calls.

      Attachments

        1. mdev8010.patch
          653 kB
          Sergey Vojtovich

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-6152 Remove calls to current_thd while creating Item

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link Github revision

          Activity

            Transition Time In Source Status Execution Times
            Sergey Vojtovich made transition -
            Open In Review
            		116d 44m 1
            Michael Widenius made transition -
            In Review Stalled
            		2d 8m 1
            Sergey Vojtovich made transition -
            Stalled Closed
            		7d 18h 56m 1

            People

              svoj Sergey Vojtovich
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.