Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-734

LP:917662 - mysql_print_status() missing final fflush()

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 5.1.67, 5.2.14, 5.3.12, 5.5.36, 10.0.9
    • 10.0.10
    • None

    Description

      See http://bugs.mysql.com/bug.php?id=64048

      Description:
      When requesting debug status output with

      mysqladmin debug

      the output in the error log (assuming that mysqld_safe was used)
      seems to be truncated at first as the mallinfo() related part
      is missing, this part will only show up in the error log when
      debug is called a 2nd time. This makes the missing part of the
      first invocation appear but then again the mallinfo() output
      for the 2nd call is missing

      How to repeat:
      Issue "mysqladmin debug", check output in mysql error log for the "Memory status:"
      section ...

      Suggested fix:
      add an extra fflush(stdout) at the very end of mysql_print_status() in sql/sql_test.cc

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          ratzpo Rasmus Johansson (Inactive) added a comment -

          Launchpad bug id: 917662

          ratzpo Rasmus Johansson (Inactive) added a comment - Launchpad bug id: 917662
          elenst Elena Stepanova added a comment -

          Fixed in 5.6.5

          elenst Elena Stepanova added a comment - Fixed in 5.6.5
          elenst Elena Stepanova added a comment -

          The upstream bug was fixed in 5.6 with the following revision:

              revno: 3402.50.249
          		 
              revision-id: praveenkumar.hulakund@oracle.com-20120224064323-7syqusja74saixbx
          		 
              parent: chaithra.gopalareddy@oracle.com-20120224063144-rmkfz8hak2oq1id4
          		 
              committer: Praveenkumar Hulakund <praveenkumar.hulakund@oracle.com>
          		 
              branch nick: trunk
          		 
              timestamp: Fri 2012-02-24 12:13:23 +0530
          		 
              message:
          		 
                Bug#13608112 - 64048: MYSQL_PRINT_STATUS() MISSING FINAL FFLUSH()
          		 
                
                Analysis:
          		 
                While printing debug information, memory related information and event
          		 
                related information were written to buffer after flushing it. Because of this,
          		 
                these information were getting printed when we do the next flush.
          		 
                
                Fix:
          		 
                Instead of calling fflush() before writing memory and event
          		 
                information, calling it after memory and event information.

          I suppose it will be fixed by the current activity of merging bugfixes from 5.6.

          elenst Elena Stepanova added a comment - The upstream bug was fixed in 5.6 with the following revision: revno: 3402.50.249 revision-id: praveenkumar.hulakund@oracle.com-20120224064323-7syqusja74saixbx parent: chaithra.gopalareddy@oracle.com-20120224063144-rmkfz8hak2oq1id4 committer: Praveenkumar Hulakund <praveenkumar.hulakund@oracle.com> branch nick: trunk timestamp: Fri 2012-02-24 12:13:23 +0530 message: Bug#13608112 - 64048: MYSQL_PRINT_STATUS() MISSING FINAL FFLUSH() Analysis: While printing debug information, memory related information and event related information were written to buffer after flushing it. Because of this, these information were getting printed when we do the next flush. Fix: Instead of calling fflush() before writing memory and event information, calling it after memory and event information. I suppose it will be fixed by the current activity of merging bugfixes from 5.6.
          monty Michael Widenius added a comment -

          Fixed in my 10.0 tree. Will be pushed shortly

          monty Michael Widenius added a comment - Fixed in my 10.0 tree. Will be pushed shortly

          People

            monty Michael Widenius
            hholzgra Hartmut Holzgraefe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.