Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
None
Description
tc_release_table is critical section of table cache. Among other things, it checks if table cache threshold is reached and if so evicts to-be-released table. This is done by comparing tc_count with tc_size.
tc_count can be atomic and checked beyond of LOCK_open. Besides it is last global variable protected by this lock.
The cost is as following:
- tc_add_table() assumed that there is nothing to evict if tc_count > tc_size and skipped expensive LRU lookup. This assumption will be broken and LRU lookup must be done if tc_count >= tc_size.
A patch for this task hasn't been benchmarked yet.
Attachments
Issue Links
- relates to
-
MDEV-4702 Reduce usage of LOCK_open
- Closed
-
MDEV-4956 Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables
- Closed
-
MDEV-5388 Reduce usage of LOCK_open: unused_tables
- Closed
-
MDEV-5492 Reduce usage of LOCK_open: TABLE::in_use
- Closed
-
MDEV-5864 Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables
- Closed
-
MDEV-5597 Reduce usage of LOCK_open: LOCK_flush
- Closed