Type:
Priority:
Resolution:
Fixed
Component/s:
None
tc_release_table is critical section of table cache. Among other things, it checks if table cache threshold is reached and if so evicts to-be-released table. This is done by comparing tc_count with tc_size.
tc_count can be atomic and checked beyond of LOCK_open. Besides it is last global variable protected by this lock.
The cost is as following:
tc_add_table() assumed that there is nothing to evict if tc_count > tc_size and skipped expensive LRU lookup. This assumption will be broken and LRU lookup must be done if tc_count >= tc_size.
A patch for this task hasn't been benchmarked yet.
{"report":{"fcp":877.9000000953674,"ttfb":154.5,"pageVisibility":"visible","entityId":27336,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"d635b4e2-a3ce-4042-b655-eae28c69c51b","navigationType":0,"readyForUser":929.1000001430511,"redirectCount":0,"resourceLoadedEnd":1054.6000001430511,"resourceLoadedStart":159.40000009536743,"resourceTiming":[{"duration":251.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":159.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":411.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":251.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":159.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":159.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":411.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":260.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":159.90000009536743,"connectEnd":159.90000009536743,"connectStart":159.90000009536743,"domainLookupEnd":159.90000009536743,"domainLookupStart":159.90000009536743,"fetchStart":159.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":159.90000009536743,"responseEnd":420.60000014305115,"responseStart":420.60000014305115,"secureConnectionStart":159.90000009536743},{"duration":286.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":159.90000009536743,"connectEnd":159.90000009536743,"connectStart":159.90000009536743,"domainLookupEnd":159.90000009536743,"domainLookupStart":159.90000009536743,"fetchStart":159.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":159.90000009536743,"responseEnd":446,"responseStart":446,"secureConnectionStart":159.90000009536743},{"duration":289.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":160.10000014305115,"connectEnd":160.10000014305115,"connectStart":160.10000014305115,"domainLookupEnd":160.10000014305115,"domainLookupStart":160.10000014305115,"fetchStart":160.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":160.10000014305115,"responseEnd":449.7000000476837,"responseStart":449.7000000476837,"secureConnectionStart":160.10000014305115},{"duration":290,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":160.20000004768372,"connectEnd":160.20000004768372,"connectStart":160.20000004768372,"domainLookupEnd":160.20000004768372,"domainLookupStart":160.20000004768372,"fetchStart":160.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":160.20000004768372,"responseEnd":450.2000000476837,"responseStart":450.2000000476837,"secureConnectionStart":160.20000004768372},{"duration":290.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":160.29999995231628,"connectEnd":160.29999995231628,"connectStart":160.29999995231628,"domainLookupEnd":160.29999995231628,"domainLookupStart":160.29999995231628,"fetchStart":160.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":160.29999995231628,"responseEnd":450.5,"responseStart":450.5,"secureConnectionStart":160.29999995231628},{"duration":290.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":160.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":450.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":290.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":160.5,"connectEnd":160.5,"connectStart":160.5,"domainLookupEnd":160.5,"domainLookupStart":160.5,"fetchStart":160.5,"redirectEnd":0,"redirectStart":0,"requestStart":160.5,"responseEnd":450.90000009536743,"responseStart":450.90000009536743,"secureConnectionStart":160.5},{"duration":290.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":160.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":160.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":451.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":290.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":160.70000004768372,"connectEnd":160.70000004768372,"connectStart":160.70000004768372,"domainLookupEnd":160.70000004768372,"domainLookupStart":160.70000004768372,"fetchStart":160.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":160.70000004768372,"responseEnd":451.5,"responseStart":451.5,"secureConnectionStart":160.70000004768372},{"duration":433.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":166.79999995231628,"connectEnd":166.79999995231628,"connectStart":166.79999995231628,"domainLookupEnd":166.79999995231628,"domainLookupStart":166.79999995231628,"fetchStart":166.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":166.79999995231628,"responseEnd":600.2999999523163,"responseStart":600.2999999523163,"secureConnectionStart":166.79999995231628},{"duration":887.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":166.90000009536743,"connectEnd":166.90000009536743,"connectStart":166.90000009536743,"domainLookupEnd":166.90000009536743,"domainLookupStart":166.90000009536743,"fetchStart":166.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":166.90000009536743,"responseEnd":1054.6000001430511,"responseStart":1054.6000001430511,"secureConnectionStart":166.90000009536743},{"duration":365.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":647.6000001430511,"connectEnd":647.6000001430511,"connectStart":647.6000001430511,"domainLookupEnd":647.6000001430511,"domainLookupStart":647.6000001430511,"fetchStart":647.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":647.6000001430511,"responseEnd":1013.2000000476837,"responseStart":1013.2000000476837,"secureConnectionStart":647.6000001430511}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":21,"responseStart":154,"responseEnd":165,"domLoading":158,"domInteractive":1073,"domContentLoadedEventStart":1073,"domContentLoadedEventEnd":1106,"domComplete":2056,"loadEventStart":2056,"loadEventEnd":2058,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1056.7000000476837},{"name":"bigPipe.sidebar-id.end","time":1057.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":1057.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":1060},{"name":"activityTabFullyLoaded","time":1111.9000000953674}],"measures":[],"correlationId":"134f3732b30d22","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":79,"dbReadsTimeInMs":13,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Task
Major
MDEV-5864 Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables