Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-4956

Reduce usage of LOCK_open: TABLE_SHARE::tdc.used_tables

    XMLWordPrintable

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.0.7
    • None
    • None

    Description

      tc_acquire_table and tc_release_table are critical sections of table cache. Among other things, they update TABLE_SHARE::tdc.used_tables:
      tc_acquire_table - push new TABLE object to used_tables
      tc_release_table - remove TABLE object from used_tables

      used_tables list is not really necessary for table cache to operate properly. We can change it with all_tables list instead. tc_acquire_table and tc_release_table wont need to access all_tables list at all.

      The cost is as following:

      • 2 additional pointers per TABLE object
      • SHOW OPEN TABLES will have to iterate all_tables and skip objects with in_use == 0
      • same for TABLE_SHARE::visit_subgraph()
      • same for kill_delayed_threads_for_table()

      A patch for this task has been tested (read-only single table OLTP, 4 CPU linux server) and shown ~30% lower LOCK_open wait time and ~20% higher tps.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-5388 Reduce usage of LOCK_open: unused_tables

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-5492 Reduce usage of LOCK_open: TABLE::in_use

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-5864 Reduce usage of LOCK_open: TABLE_SHARE::tdc.free_tables

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-4702 Reduce usage of LOCK_open

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-5403 Reduce usage of LOCK_open: tc_count

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-5597 Reduce usage of LOCK_open: LOCK_flush

          • Major - Major loss of function.
          • Closed

          Activity

            People

              serg Sergei Golubchik
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.