Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-34361

wait for slave timeout when running mtr --reorder spider.connection_override spider.slave_trx_isolation

Details

    Description

      This is a problem with fragility of the spider suite.

      When we place the connection_override test added in MDEV-32627/MDEV-34359 under the spider suite, as opposed to the spider/bugfix suite, we get timeout when running the test before running spider.slave_trx_isolation (e.g. with mtr --no-reorder spider.connection_override spider.slave_trx_isolation):

      CURRENT_TEST: spider.slave_trx_isolation
      mysqltest: In included file "./include/wait_for_slave_param.inc":
      included from ./include/wait_for_slave_sql_to_start.inc at line 33:
      included from ./include/wait_for_slave_to_start.inc at line 28:
      included from ./include/start_slave.inc at line 35:
      included from /home/buildbot/amd64-centos-7/build/storage/spider/mysql-test/spider/t/../include/../t/slave_test_init.inc at line 24:
      included from /home/buildbot/amd64-centos-7/build/storage/spider/mysql-test/spider/t/../include/slave_trx_isolation_init.inc at line 6:
      included from /home/buildbot/amd64-centos-7/build/storage/spider/mysql-test/spider/t/slave_trx_isolation.test at line 2:
      At line 111: Timeout in include/wait_for_slave_param.inc
      

      For example, see https://buildbot.mariadb.org/#/builders/146/builds/34278, at commit 0a06f298bc179dbbc8cc078cb92ca12de17ca184

      One could see patterns in mysqld.4.1.log of repeated pattern like so:

      240607  7:31:30	   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      		   103 Query	SHOW SLAVE STATUS
      		   103 Query	SELECT NOT('No' = 'Yes')
      

      Attachments

        Issue Links

          Activity

            ycp Yuchen Pei added a comment - - edited

            Hi holyfoot, ptal thanks

            upstream/bb-10.5-mdev-34361 b22080568d5acfe0bb0969aac86b4a4937620663
            MDEV-34361 Split my.cnf in the spider suite.
             
            Just like the spider/bugfix suite.
             
            One caveat is that my_2_3.cnf needs something under mysqld.2.3 group,
            otherwise mtr will fail with something like:
             
            There is no group named 'mysqld.2.3' that can be used to resolve
            'port' for ...
             
            This will allow new tests under the spider suite to use what is
            needed. It also somehow fixes issues of running a test followed by
            spider.slave_trx_isolation.
            

            With this change, we can push MDEV-34359, which is the 10.5 version of one of the approved commits from MDEV-32627

            ff51cecbc46 bb-10.5-mdev-34359 MDEV-32627 Spider: add tests for connection param overriding
            

            This change will need to be included in the push for MDEV-32627 but let's not keep re-reviewing that ticket

            ycp Yuchen Pei added a comment - - edited Hi holyfoot , ptal thanks upstream/bb-10.5-mdev-34361 b22080568d5acfe0bb0969aac86b4a4937620663 MDEV-34361 Split my.cnf in the spider suite.   Just like the spider/bugfix suite.   One caveat is that my_2_3.cnf needs something under mysqld.2.3 group, otherwise mtr will fail with something like:   There is no group named 'mysqld.2.3' that can be used to resolve 'port' for ...   This will allow new tests under the spider suite to use what is needed. It also somehow fixes issues of running a test followed by spider.slave_trx_isolation. With this change, we can push MDEV-34359 , which is the 10.5 version of one of the approved commits from MDEV-32627 ff51cecbc46 bb-10.5-mdev-34359 MDEV-32627 Spider: add tests for connection param overriding This change will need to be included in the push for MDEV-32627 but let's not keep re-reviewing that ticket

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            thanks for the review - pushed 01289dac4148da50c9bd13b07447d158fe0050c1 to 10.5

            ycp Yuchen Pei added a comment - thanks for the review - pushed 01289dac4148da50c9bd13b07447d158fe0050c1 to 10.5

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.