Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32627

Spider: Add CONNECTION parsing of SQLDriverConnect format when the wrapper is odbc

Details

    Attachments

      Issue Links

        is blocked by

        Bug - A problem which impairs or prevents the functions of the product. MDEV-34361 wait for slave timeout when running mtr --reorder spider.connection_override spider.slave_trx_isolation

        • Critical - Crashes, loss of data, severe memory leak.
        • Closed
        relates to

        New Feature - A new feature of the product, which has yet to be developed. MDEV-33326 Port Spider/ODBC from ES

        • Major - Major loss of function.
        • Open

        Task - A task that needs to be done. MDEV-34359 Spider: add tests for connection param overriding

        • Major - Major loss of function.
        • Closed

        Activity

          Ascending order - Click to sort in descending order
          View 12 older comments
          ycp Yuchen Pei added a comment - - edited

          Thanks for the review. Amended the commits to:

          db5bf1cb322 upstream/bb-11.4-mdev-32627 MDEV-32627 Spider: use CONNECTION string in SQLDriverConnect
          		 
          96e722eecfe MDEV-32627 Distinguish between absence of a keyword and empty value for the keyword
          		 
          9279608e87c MDEV-32627 Spider: add tests for connection param overriding

          For 11.4-ES:

          7f007e41331 11.4-enterprise-mdev-32627 MDEV-32627 Spider: use CONNECTION string in SQLDriverConnect
          		 
          4c0e52c369b MDEV-32627 Distinguish between absence of a keyword and empty value for the keyword
          		 
          43fa5931391 MDEV-32627 Spider: add tests for connection param overriding

          As part of MENT-2070, this ticket is now blocked by TODO-4629.

          Meanwhile I will push the bottom commit, which simply adds a test, to 10.5.

          ycp Yuchen Pei added a comment - - edited Thanks for the review. Amended the commits to: db5bf1cb322 upstream/bb-11.4-mdev-32627 MDEV-32627 Spider: use CONNECTION string in SQLDriverConnect 96e722eecfe MDEV-32627 Distinguish between absence of a keyword and empty value for the keyword 9279608e87c MDEV-32627 Spider: add tests for connection param overriding For 11.4-ES: 7f007e41331 11.4-enterprise-mdev-32627 MDEV-32627 Spider: use CONNECTION string in SQLDriverConnect 4c0e52c369b MDEV-32627 Distinguish between absence of a keyword and empty value for the keyword 43fa5931391 MDEV-32627 Spider: add tests for connection param overriding As part of MENT-2070, this ticket is now blocked by TODO-4629. Meanwhile I will push the bottom commit, which simply adds a test, to 10.5.
          ycp Yuchen Pei added a comment - - edited

          A fixup commit (in bb-10.5-ycp) that should be pushed when pushing this ticket

          bef1cf17290 MDEV-32627 [fixup] Spider: Fix conn key length

          Without this fix, the MDEV-29962 fix would cause a hang in spider.spider_fixes.

          ycp Yuchen Pei added a comment - - edited A fixup commit (in bb-10.5-ycp) that should be pushed when pushing this ticket bef1cf17290 MDEV-32627 [fixup] Spider: Fix conn key length Without this fix, the MDEV-29962 fix would cause a hang in spider.spider_fixes.
          ycp Yuchen Pei added a comment -

          Pushed the bottom two commits and the fixup commit to 10.5 as MDEV-34359

          ycp Yuchen Pei added a comment - Pushed the bottom two commits and the fixup commit to 10.5 as MDEV-34359
          ycp Yuchen Pei added a comment -

          pending testing of MENT-2070 done

          ycp Yuchen Pei added a comment - pending testing of MENT-2070 done
          ycp Yuchen Pei added a comment -

          pushed 18d3f63a4e406e2a445e9a62520cf08c0f5b6030 to 11.4

          ycp Yuchen Pei added a comment - pushed 18d3f63a4e406e2a445e9a62520cf08c0f5b6030 to 11.4

          People

            ycp Yuchen Pei
            ycp Yuchen Pei
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.