Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
11.0, 11.1, 11.2, 11.3, 11.4
-
Solaris 11.4/amd64
Description
To provide patches for the Solaris build issues I've reported before against MariaDB 10.11.6, I've tried a build on 11.4 instead. Unfortunately, there's a new build failure there:
```
/vol/src/mariadb/mariadb-server/storage/innobase/os/os0file.cc: In function ‘pfs_os_file_t os_file_create_func(const char*, ulint, ulint, ulint, bool, bool*)’:
/vol/src/mariadb/mariadb-server/storage/innobase/os/os0file.cc:1233:49: error: ‘mode_str’ was not declared in this scope; did you mean ‘mode_t’?
1233 | os_file_set_nocache(file, name, mode_str);
| ^~~~~~~~ |
| mode_t ``` While all other uses of `mode_str` are wrapped in `#ifdef O_DIRECT`, this one is not, which breaks the Solaris build which lacks `O_DIRECT`. |
Fixed by wrapping that case in `#ifdef O_DIRECT`, too.
Attachments
Issue Links
- is blocked by
-
-
- Closed
-
- is caused by
-
MDEV-30136 Map innodb_flush_method to new settable Booleans innodb_{log,data}_file_{buffering,write_through}
-
- Closed
-