Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32804

Remove the (unimplemented and unused) spider_rewrite_plugin

Details

    Description

      spider_rewrite_plugin was added in

      fa7051c419a653a002282eaca60f8202c1066d61
      MDEV-19842 Crash while creating statistics for Spider table (#1355)
       
      Added checks of the number of columns of the system tables.
      Move install_spider.sql into source code except installing Spider
      

      as a stub, but never implemented (e.g. the relevant system tables are never used). There's no design documentation what it is meant for except the brief /* table for ddl pushdown */ before the create table statements that create the relevant system tables. And there's no design documentation on how it should be implemented.

      Nayuta also mentioned on slack it is for create table pushdown (MDEV-16967)

      nayuta 2 years ago
      spider_rewrite is not loaded for 10.4. It is for CREATE TABLE pushdown and planned to be included in 10.7 (but actually not).
      5 replies
      ralf 2 years ago
      https://jira.mariadb.org/browse/MDEV-16967
      ralf 2 years ago
      it would be new to me that is was planned to be included in 10.7
      ralf 2 years ago
      I could not find the MDEV but there was some relation to an audit plugin related topic. Anyhow, spider_rewrite should not even exist currently in 10.4-10.8
      nayuta 2 years ago
      I guess so from the code (especially, spider_init_queries) written by Kentoku. And, yes, it doesn't exist on any major branch.

      The system table creations is already removed in MDEV-27095 which applies to 10.10, and will be backported to 10.4-6 as part of MDEV-29870. Remove the remaining references.

      Attachments

        Issue Links

          Activity

            ycp Yuchen Pei created issue -
            ycp Yuchen Pei made changes -
            Field Original Value New Value
            Description spider_rewrite_plugin was added in
            {noformat}
            fa7051c419a653a002282eaca60f8202c1066d61
            MDEV-19842 Crash while creating statistics for Spider table (#1355)

            Added checks of the number of columns of the system tables.
            Move install_spider.sql into source code except installing Spider
            {noformat}
            as a stub, but never implemented (e.g. the relevant system tables are never used). There's no design documentation what it is meant for except the brief {{/* table for ddl pushdown */}} before the {{create table}} statements that create the relevant system tables. And there's no design documentation on how it should be implemented.

            Nayuta also mentioned on slack it is for create table pushdown (MDEV-16967)

            {quote}
             nayuta 2 years ago
            spider_rewrite is not loaded for 10.4. It is for CREATE TABLE pushdown and planned to be included in 10.7 (but actually not).
            5 replies
             ralf 2 years ago
            https://jira.mariadb.org/browse/MDEV-16967
             ralf 2 years ago
            it would be new to me that is was planned to be included in 10.7
             ralf 2 years ago
            I could not find the MDEV but there was some relation to an audit plugin related topic. Anyhow, spider_rewrite should not even exist currently in 10.4-10.8
             nayuta 2 years ago
            I guess so from the code (especially, spider_init_queries) written by Kentoku. And, yes, it doesn't exist on any major branch.
            {quote}
             
            The system table creations is already removed in MDEV-27095 which applies to 10.10, and will be backported to 10.4-6 as part of MDEV-29870. Remove the tables
            spider_rewrite_plugin was added in
            {noformat}
            fa7051c419a653a002282eaca60f8202c1066d61
            MDEV-19842 Crash while creating statistics for Spider table (#1355)

            Added checks of the number of columns of the system tables.
            Move install_spider.sql into source code except installing Spider
            {noformat}
            as a stub, but never implemented (e.g. the relevant system tables are never used). There's no design documentation what it is meant for except the brief {{/* table for ddl pushdown */}} before the {{create table}} statements that create the relevant system tables. And there's no design documentation on how it should be implemented.

            Nayuta also mentioned on slack it is for create table pushdown (MDEV-16967)

            {quote}
             nayuta 2 years ago
            spider_rewrite is not loaded for 10.4. It is for CREATE TABLE pushdown and planned to be included in 10.7 (but actually not).
            5 replies
             ralf 2 years ago
            https://jira.mariadb.org/browse/MDEV-16967
             ralf 2 years ago
            it would be new to me that is was planned to be included in 10.7
             ralf 2 years ago
            I could not find the MDEV but there was some relation to an audit plugin related topic. Anyhow, spider_rewrite should not even exist currently in 10.4-10.8
             nayuta 2 years ago
            I guess so from the code (especially, spider_init_queries) written by Kentoku. And, yes, it doesn't exist on any major branch.
            {quote}
             
            The system table creations is already removed in MDEV-27095 which applies to 10.10, and will be backported to 10.4-6 as part of MDEV-29870. Remove the remaining references.
            ycp Yuchen Pei made changes -
            Summary Remove the (unused) spider_rewrite_plugin Remove the (unimplemented and unused) spider_rewrite_plugin
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ycp Yuchen Pei made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            ycp Yuchen Pei made changes -
            Assignee Yuchen Pei [ JIRAUSER52627 ] Alexey Botchkov [ holyfoot ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            holyfoot Alexey Botchkov made changes -
            Assignee Alexey Botchkov [ holyfoot ] Yuchen Pei [ JIRAUSER52627 ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            ycp Yuchen Pei made changes -
            Fix Version/s 10.4.33 [ 29516 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.6 [ 24028 ]
            Fix Version/s 10.11 [ 27614 ]
            Fix Version/s 11.0 [ 28320 ]
            Fix Version/s 11.1 [ 28549 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            ycp Yuchen Pei made changes -
            Fix Version/s 10.5.24 [ 29517 ]
            Fix Version/s 10.6.17 [ 29518 ]
            Fix Version/s 10.11.7 [ 29519 ]
            Fix Version/s 11.0.5 [ 29520 ]
            Fix Version/s 11.1.4 [ 29024 ]

            People

              ycp Yuchen Pei
              ycp Yuchen Pei
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.