[MDEV-32804] Remove the (unimplemented and unused) spider_rewrite_plugin Created: 2023-11-14  Updated: 2023-11-27  Resolved: 2023-11-24

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Spider
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4

Type: Task Priority: Critical
Reporter: Yuchen Pei Assignee: Yuchen Pei
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-29870 Backport fixes to spider init bugs to... Closed
relates to MDEV-16967 Spider CREATE TABLE Pushdown Stalled
relates to MDEV-27095 Simplify spider init queries Closed

 Description   

spider_rewrite_plugin was added in

fa7051c419a653a002282eaca60f8202c1066d61
 
MDEV-19842 Crash while creating statistics for Spider table (#1355)
 
 
 
Added checks of the number of columns of the system tables.
 
Move install_spider.sql into source code except installing Spider

as a stub, but never implemented (e.g. the relevant system tables are never used). There's no design documentation what it is meant for except the brief /* table for ddl pushdown */ before the create table statements that create the relevant system tables. And there's no design documentation on how it should be implemented.

Nayuta also mentioned on slack it is for create table pushdown (MDEV-16967)

nayuta 2 years ago
spider_rewrite is not loaded for 10.4. It is for CREATE TABLE pushdown and planned to be included in 10.7 (but actually not).
5 replies
ralf 2 years ago
https://jira.mariadb.org/browse/MDEV-16967
ralf 2 years ago
it would be new to me that is was planned to be included in 10.7
ralf 2 years ago
I could not find the MDEV but there was some relation to an audit plugin related topic. Anyhow, spider_rewrite should not even exist currently in 10.4-10.8
nayuta 2 years ago
I guess so from the code (especially, spider_init_queries) written by Kentoku. And, yes, it doesn't exist on any major branch.

The system table creations is already removed in MDEV-27095 which applies to 10.10, and will be backported to 10.4-6 as part of MDEV-29870. Remove the remaining references.

 Comments   
Comment by Yuchen Pei [ 2023-11-15 ]

An initial commit:

afe14ab0f34 bb-10.4-mdev-29870 MDEV-32804 Remove references to spider_rewrite_plugin tables

Comment by Yuchen Pei [ 2023-11-16 ]

Hi holyfoot, ptal thanks (based on 10.4):

upstream/bb-10.4-mdev-29870 fc197aef87ca20a169ee7b237b44c6508de0e95a
 
MDEV-32804 Remove references to spider_rewrite_plugin tables
 
 
 
They are not used. The code paths are never reached.

Here's a 10.11 version
604606d5b01042bdf25e059695986148f141d95f

Comment by Alexey Botchkov [ 2023-11-23 ]

ok to push.

Comment by Yuchen Pei [ 2023-11-24 ]

Pushed the following to 10.4 (the second is a minor fix on a test to make the CI happy)

1a76d751c56 upstream/bb-10.4-mdev-32804 upstream/10.4 MDEV-32804 Remove references to spider_rewrite_plugin tables
 
ed0ab6e1893 MDEV-27575 Add sleeping statement spider/bugfix.mdev_27575

Generated at Thu Feb 08 10:34:08 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.