Remove the (unimplemented and unused) spider_rewrite_plugin

spider_rewrite_plugin was added in

fa7051c419a653a002282eaca60f8202c1066d61

MDEV-19842 Crash while creating statistics for Spider table (#1355)

Added checks of the number of columns of the system tables.

Move install_spider.sql into source code except installing Spider

as a stub, but never implemented (e.g. the relevant system tables are never used). There's no design documentation what it is meant for except the brief /* table for ddl pushdown */ before the create table statements that create the relevant system tables. And there's no design documentation on how it should be implemented.

Nayuta also mentioned on slack it is for create table pushdown (MDEV-16967)

nayuta 2 years ago
spider_rewrite is not loaded for 10.4. It is for CREATE TABLE pushdown and planned to be included in 10.7 (but actually not).
5 replies
ralf 2 years ago
https://jira.mariadb.org/browse/MDEV-16967
ralf 2 years ago
it would be new to me that is was planned to be included in 10.7
ralf 2 years ago
I could not find the MDEV but there was some relation to an audit plugin related topic. Anyhow, spider_rewrite should not even exist currently in 10.4-10.8
nayuta 2 years ago
I guess so from the code (especially, spider_init_queries) written by Kentoku. And, yes, it doesn't exist on any major branch.

The system table creations is already removed in MDEV-27095 which applies to 10.10, and will be backported to 10.4-6 as part of MDEV-29870. Remove the remaining references.