[MDEV-32725] innodb.import_update_stats accesses uninitialized ib_table->stat_n_rows - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5, 10.6, 10.7(EOL), 10.8(EOL), 10.9(EOL), 10.10(EOL), 10.11, 11.0(EOL), 11.1(EOL), 11.2(EOL)
Fix Version/s: 10.4.33, 10.5.24, 10.6.17, 10.11.7, 11.0.5, 11.1.4, 11.2.3
Component/s: Storage Engine - InnoDB
Labels:
- MSAN
- valgrind

Description

The test innodb.import_update_stats that will be added in ~~MDEV-13626~~ is failing on Valgrind, and on 10.5 on MSAN. The following patch would almost fix it:

diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc

index 086f30e119e..33ac21a4a7e 100644

--- a/storage/innobase/handler/ha_innodb.cc

+++ b/storage/innobase/handler/ha_innodb.cc

@@ -14316,7 +14316,7 @@ ha_innobase::info_low(

 	DBUG_ASSERT(ib_table->get_ref_count() > 0);

 	if (!ib_table->is_readable()) {

-		ib_table->stat_initialized = true;

+		goto func_exit;

 	if (flag & HA_STATUS_TIME) {

However, this patch would make a number of other tests fail:

10.4 2447172afb5afed1687779e46eed217c38f89ebc with patch
Failing test(s): encryption.innodb-bad-key-change3 innodb.innodb_bug14147491 innodb.innodb-wl5522-debug innodb_zip.wl5522_debug_zip

Attachments

Issue Links

relates to

MDEV-13626 Merge InnoDB test cases from MySQL 5.7

Closed

Activity

People

Assignee:: Thirunarayanan Balathandayuthapani

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2023-11-07 11:29

Updated:: 2023-12-18 08:20

Resolved:: 2023-12-15 11:06

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server