[MDEV-32374] log_sys.lsn_lock is a performance hog - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.11, 11.1(EOL), 11.2, 10.8(EOL), 10.9(EOL), 10.10(EOL), 11.0(EOL), 11.3(EOL)
Fix Version/s: 10.11.7, 11.0.5, 11.1.4, 11.2.3, 11.3.2
Component/s: Storage Engine - InnoDB
Labels:
- performance

Description

~~MDEV-27774~~ made it possible to for multiple mtr_t::commit() to write to log_sys.buf concurrently, by replacing the InnoDB log_sys.mutex with log_sys.latch and log_sys.lsn_lock. The latter appears to be a performance bottleneck.

Because we need to keep multiple log_sys data members consistent with each other, we cannot simply invoke std::atomic::fetch_add and std::atomic::compare_exchange_weak on log_sys.buf_free to achieve a similar result. But, we could try to fit more data members in the same single cache line with log_sys.latch.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

b58e1ce.png
31 kB
2023-11-17 11:50

Issue Links

is caused by

MDEV-27774 Reduce scalability bottlenecks in mtr_t::commit()

Closed

relates to

MDEV-27866 Switching log_sys.latch to use spin based variant

Closed

MDEV-33515 log_sys.lsn_lock causes excessive context switching

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2023-10-09 04:53

Updated:: 2024-03-01 14:00

Resolved:: 2023-11-21 13:19

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.