[MDEV-32369] Memory leak when executing PS for query with IN subquery - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.4(EOL), 10.5, 10.6, 10.11, 11.0(EOL)
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3
Component/s: Prepared Statements
Labels:
None

Description

For the following test case a statement memory leak is detected when the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON

CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;

CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;

INSERT INTO t1 VALUES ('b'), ('a'), ('c');

INSERT INTO t2 VALUES ('c'), ('d'), ('b');

PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";

EXECUTE stmt;

EXECUTE stmt;

DEALLOCATE PREPARE stmt;

DROP TABLE t1,t2;

The leak is detected in the function Type_std_attributes::agg_item_set_converter()
with the following memory allocation

       Item_direct_ref_to_item *ref=

         new (thd->mem_root) Item_direct_ref_to_item(thd, *arg);

Attachments

Issue Links

blocks

MDEV-14959 Control over memory allocated for SP/PS

Closed

relates to

MDEV-32569 Failure when executing PS for query using IN subquery

Closed

Activity

Ascending order - Click to sort in descending order

Igor Babaev (Inactive) created issue - 2023-10-06 18:45

Igor Babaev (Inactive) made changes - 2023-10-06 18:59

Field	Original Value	New Value
Priority	Major [ 3 ]	Critical [ 2 ]

Igor Babaev (Inactive) made changes - 2023-10-13 07:15

Assignee

Igor Babaev [ igor ]

Dmitry Shulga [ JIRAUSER47315 ]

Igor Babaev (Inactive) made changes - 2023-10-13 07:17

Link

This issue blocks ~~MDEV-14959~~ [ ~~MDEV-14959~~ ]

Dmitry Shulga made changes - 2023-10-17 08:10

Status

Open [ 1 ]

In Progress [ 3 ]

Dmitry Shulga added a comment - 2023-10-17 08:11

The branch for review is bb-10.4-~~MDEV-32369~~

Dmitry Shulga added a comment - 2023-10-17 08:11 The branch for review is bb-10.4- MDEV-32369

Dmitry Shulga made changes - 2023-10-17 08:11

Assignee	Dmitry Shulga [ JIRAUSER47315 ]	Oleksandr Byelkin [ sanja ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Oleksandr Byelkin added a comment - 2023-10-17 08:32

OK to push

Oleksandr Byelkin added a comment - 2023-10-17 08:32 OK to push

Oleksandr Byelkin made changes - 2023-10-17 08:32

Assignee	Oleksandr Byelkin [ sanja ]	Dmitry Shulga [ JIRAUSER47315 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Dmitry Shulga made changes - 2023-10-18 05:44

Fix Version/s		10.4.32 [ 29300 ]
Fix Version/s		10.5.23 [ 29012 ]
Fix Version/s		10.6.16 [ 29014 ]
Fix Version/s		10.10.7 [ 29018 ]
Fix Version/s		10.11.6 [ 29020 ]
Fix Version/s		11.0.4 [ 29021 ]
Fix Version/s		11.1.3 [ 29023 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Igor Babaev (Inactive) made changes - 2023-10-23 20:04

Description

For the following test case a statement memory leak is detected when the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON
{code:sql}
CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;
CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;
INSERT INTO t1 VALUES ('b'), ('a'), ('c');
INSERT INTO t2 VALUES ('c'), ('d'), ('b');
PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";
EXECUTE stmt;
EXECUTE stmt;
DEALLOCATE PREPARE stmt;
DROP TABLE t1,t1;
{code}
The leak is detected in the function Type_std_attributes::agg_item_set_converter()
with the following memory allocation
{code}
Item_direct_ref_to_item *ref=
new (thd->mem_root) Item_direct_ref_to_item(thd, *arg);
{code}

For the following test case a statement memory leak is detected when the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON
{code:sql}
CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;
CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;
INSERT INTO t1 VALUES ('b'), ('a'), ('c');
INSERT INTO t2 VALUES ('c'), ('d'), ('b');
PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";
EXECUTE stmt;
EXECUTE stmt;
DEALLOCATE PREPARE stmt;
DROP TABLE t1,t2
;
{code}
The leak is detected in the function Type_std_attributes::agg_item_set_converter()
with the following memory allocation
{code}
Item_direct_ref_to_item *ref=
new (thd->mem_root) Item_direct_ref_to_item(thd, *arg);
{code}

Igor Babaev (Inactive) made changes - 2023-10-24 21:46

Description

For the following test case a statement memory leak is detected when the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON
{code:sql}
CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;
CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;
INSERT INTO t1 VALUES ('b'), ('a'), ('c');
INSERT INTO t2 VALUES ('c'), ('d'), ('b');
PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";
EXECUTE stmt;
EXECUTE stmt;
DEALLOCATE PREPARE stmt;
DROP TABLE t1,t2
;
{code}
The leak is detected in the function Type_std_attributes::agg_item_set_converter()
with the following memory allocation
{code}
Item_direct_ref_to_item *ref=
new (thd->mem_root) Item_direct_ref_to_item(thd, *arg);
{code}

For the following test case a statement memory leak is detected when the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON
{code:sql}
CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;
CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;
INSERT INTO t1 VALUES ('b'), ('a'), ('c');
INSERT INTO t2 VALUES ('c'), ('d'), ('b');
PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";
EXECUTE stmt;
EXECUTE stmt;
DEALLOCATE PREPARE stmt;
DROP TABLE t1,t2;
{code}
The leak is detected in the function Type_std_attributes::agg_item_set_converter()
with the following memory allocation
{code}
Item_direct_ref_to_item *ref=
new (thd->mem_root) Item_direct_ref_to_item(thd, *arg);
{code}

Igor Babaev (Inactive) made changes - 2023-10-24 23:45

Link

This issue relates to ~~MDEV-32569~~ [ ~~MDEV-32569~~ ]

Igor Babaev (Inactive) added a comment - 2023-10-25 17:36

The following test case fails if the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON

CREATE TABLE t1 (a varchar(10)) ENGINE=MYISAM;

CREATE TABLE t2 (b varchar(10) CHARACTER SET utf8) ENGINE=MYISAM;

INSERT INTO t1 VALUES ('b'), ('a'), ('c');

INSERT INTO t2 VALUES ('c'), ('d'), ('b');

PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)";

EXECUTE stmt;

EXECUTE stmt;

DEALLOCATE PREPARE stmt;

DROP TABLE t1,t2;

Igor Babaev (Inactive) added a comment - 2023-10-25 17:36 The following test case fails if the server is built with -DWITH_PROTECT_STATEMENT_MEMROOT:BOOL=ON CREATE TABLE t1 (a varchar (10)) ENGINE=MYISAM; CREATE TABLE t2 (b varchar (10) CHARACTER SET utf8) ENGINE=MYISAM; INSERT INTO t1 VALUES ( 'b' ), ( 'a' ), ( 'c' ); INSERT INTO t2 VALUES ( 'c' ), ( 'd' ), ( 'b' ); PREPARE stmt FROM "SELECT t1.a FROM t1 WHERE t1.a IN (SELECT t2.b FROM t2)" ; EXECUTE stmt; EXECUTE stmt; DEALLOCATE PREPARE stmt; DROP TABLE t1,t2;

People

Assignee:: Dmitry Shulga

Reporter:: Igor Babaev (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 2023-10-06 18:45

Updated:: 2023-10-31 21:45

Resolved:: 2023-10-18 05:44

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration