Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-32234

Missing spaces in Spider variable descriptions

Details

    Description

      The two newly-added 11.3.0 Spider system variables both have typos in their description.
      'stringswithout' and 'stringsare' respectively:

      SELECT VARIABLE_NAME,VARIABLE_COMMENT FROM INFORMATION_SCHEMA.SYSTEM_VARIABLES WHERE VARIABLE_NAME LIKE 'spider_suppress_%' OR VARIABLE_NAME LIKE 'spider_igno%'\G
      		 
      *************************** 1. row ***************************
      		 
         VARIABLE_NAME: SPIDER_SUPPRESS_COMMENT_IGNORED_WARNING
      		 
      VARIABLE_COMMENT: Whether to suppress warnings that table COMMENT or CONNECTION stringsare ignored due to specified table options
      		 
      *************************** 2. row ***************************
      		 
         VARIABLE_NAME: SPIDER_IGNORE_COMMENTS
      		 
      VARIABLE_COMMENT: Whether to unconditionally ignore COMMENT and CONNECTION stringswithout checking whether table options are specified

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-28856 Spider: Implement more engine-defined options

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ycp Yuchen Pei added a comment -

            amended:
            b5aa7699b53 * MDEV-28856 Add remaining Spider table options
            (was a4031e4c051, part of preview-11.3-preview)

            ycp Yuchen Pei added a comment - amended: b5aa7699b53 * MDEV-28856 Add remaining Spider table options (was a4031e4c051, part of preview-11.3-preview)
            ycp Yuchen Pei added a comment - - edited

            Following up on serg's suggestion, Roel please apply the trivial commit 27bbea53c20a6f46f6fcbc43055a48df73226997 when testing MDEV-28856:

            https://github.com/MariaDB/server/commit/27bbea53c20

            ycp Yuchen Pei added a comment - - edited Following up on serg 's suggestion, Roel please apply the trivial commit 27bbea53c20a6f46f6fcbc43055a48df73226997 when testing MDEV-28856 : https://github.com/MariaDB/server/commit/27bbea53c20
            Roel Roel Van de Paar added a comment -

            Actioned as suggested

            Roel Roel Van de Paar added a comment - Actioned as suggested
            ycp Yuchen Pei added a comment -

            will be squashed into the MDEV-28856 patch

            ycp Yuchen Pei added a comment - will be squashed into the MDEV-28856 patch

            People

              ycp Yuchen Pei
              greenman Ian Gilfillan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.