[MDEV-32234] Missing spaces in Spider variable descriptions Created: 2023-09-23  Updated: 2023-10-27  Resolved: 2023-10-27

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Spider
Affects Version/s: 11.3.0
Fix Version/s: 11.3.1

Type: Bug Priority: Trivial
Reporter: Ian Gilfillan Assignee: Yuchen Pei
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
PartOf
is part of MDEV-28856 Spider: Implement more engine-defined... Closed

 Description   

The two newly-added 11.3.0 Spider system variables both have typos in their description.
'stringswithout' and 'stringsare' respectively:

SELECT VARIABLE_NAME,VARIABLE_COMMENT FROM INFORMATION_SCHEMA.SYSTEM_VARIABLES WHERE VARIABLE_NAME LIKE 'spider_suppress_%' OR VARIABLE_NAME LIKE 'spider_igno%'\G
 
*************************** 1. row ***************************
 
   VARIABLE_NAME: SPIDER_SUPPRESS_COMMENT_IGNORED_WARNING
 
VARIABLE_COMMENT: Whether to suppress warnings that table COMMENT or CONNECTION stringsare ignored due to specified table options
 
*************************** 2. row ***************************
 
   VARIABLE_NAME: SPIDER_IGNORE_COMMENTS
 
VARIABLE_COMMENT: Whether to unconditionally ignore COMMENT and CONNECTION stringswithout checking whether table options are specified



 Comments   
Comment by Yuchen Pei [ 2023-09-25 ]

amended:
b5aa7699b53 * MDEV-28856 Add remaining Spider table options
(was a4031e4c051, part of preview-11.3-preview)

Comment by Yuchen Pei [ 2023-09-25 ]

Following up on serg's suggestion, Roel please apply the trivial commit 27bbea53c20a6f46f6fcbc43055a48df73226997 when testing MDEV-28856:

https://github.com/MariaDB/server/commit/27bbea53c20

Comment by Roel Van de Paar [ 2023-10-14 ]

Actioned as suggested

Comment by Yuchen Pei [ 2023-10-27 ]

will be squashed into the MDEV-28856 patch

Generated at Thu Feb 08 10:29:50 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.