[MDEV-31936] Simplify deinit_spider.inc - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3
Component/s: Storage Engine - Spider
Labels:
None

Description

Noticed this while working on another ticket.

After ~~MDEV-31421~~, we can further simplify this file.

Attachments

Activity

Ascending order - Click to sort in descending order

Yuchen Pei added a comment - 2023-08-17 01:03 - edited

A PoC https://github.com/MariaDB/server/commit/2973d6b1b9a

There are probably other things we can do to simplify other spider .inc files. Will sleep on it for a few days just in case.

Yuchen Pei added a comment - 2023-08-17 01:03 - edited A PoC https://github.com/MariaDB/server/commit/2973d6b1b9a There are probably other things we can do to simplify other spider .inc files. Will sleep on it for a few days just in case.

Yuchen Pei added a comment - 2023-09-15 06:10

Hi holyfoot, ptal thanks:

https://github.com/MariaDB/server/commit/2973d6b1b9a

Yuchen Pei added a comment - 2023-09-15 06:10 Hi holyfoot , ptal thanks: https://github.com/MariaDB/server/commit/2973d6b1b9a

Alexey Botchkov added a comment - 2023-09-21 11:18

looks ok to push.

Alexey Botchkov added a comment - 2023-09-21 11:18 looks ok to push.

Yuchen Pei added a comment - 2023-09-25 02:18 - edited

Thanks for the review holyfoot.

Pushed b6773f58196d74e0a0be83b4499fcb82799e1144 to 10.4, and merged into 10.5.
Tested 10.4-11.2, ES-10.4,10.6,23.08. Conflicts and resolutions:

10.4->10.5: aa9dd3d22483899375f8eb477458053a650115b7 drop s_1 too
10.6->10.10: 73ddb5f37a39949bd927eda726605793764c5343 mtrec spider/bugfix.index

Yuchen Pei added a comment - 2023-09-25 02:18 - edited Thanks for the review holyfoot . Pushed b6773f58196d74e0a0be83b4499fcb82799e1144 to 10.4, and merged into 10.5. Tested 10.4-11.2, ES-10.4,10.6,23.08. Conflicts and resolutions: 10.4->10.5: aa9dd3d22483899375f8eb477458053a650115b7 drop s_1 too 10.6->10.10: 73ddb5f37a39949bd927eda726605793764c5343 mtrec spider/bugfix.index

People

Assignee:: Yuchen Pei

Reporter:: Yuchen Pei

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2023-08-17 00:58

Updated:: 2023-10-19 06:06

Resolved:: 2023-09-25 03:18

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server