[MDEV-31936] Simplify deinit_spider.inc Created: 2023-08-17 Updated: 2023-10-19 Resolved: 2023-09-25 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Storage Engine - Spider |
| Fix Version/s: | 10.4.32, 10.5.23, 10.6.16, 10.10.7, 10.11.6, 11.0.4, 11.1.3 |
| Type: | Task | Priority: | Major |
| Reporter: | Yuchen Pei | Assignee: | Yuchen Pei |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Noticed this while working on another ticket. After |
| Comments |
| Comment by Yuchen Pei [ 2023-08-17 ] |
|
A PoC https://github.com/MariaDB/server/commit/2973d6b1b9a There are probably other things we can do to simplify other spider .inc files. Will sleep on it for a few days just in case. |
| Comment by Yuchen Pei [ 2023-09-15 ] |
|
Hi holyfoot, ptal thanks: |
| Comment by Alexey Botchkov [ 2023-09-21 ] |
|
looks ok to push. |
| Comment by Yuchen Pei [ 2023-09-25 ] |
|
Thanks for the review holyfoot. Pushed b6773f58196d74e0a0be83b4499fcb82799e1144 to 10.4, and merged into 10.5.
|