Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31936

Simplify deinit_spider.inc

Details

    Description

      Noticed this while working on another ticket.

      After MDEV-31421, we can further simplify this file.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          ycp Yuchen Pei created issue -
          ycp Yuchen Pei made changes -
          Field Original Value New Value
          Component/s Storage Engine - Spider [ 10132 ]
          ycp Yuchen Pei made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ]
          ycp Yuchen Pei added a comment - - edited

          A PoC https://github.com/MariaDB/server/commit/2973d6b1b9a

          There are probably other things we can do to simplify other spider .inc files. Will sleep on it for a few days just in case.

          ycp Yuchen Pei added a comment - - edited A PoC https://github.com/MariaDB/server/commit/2973d6b1b9a There are probably other things we can do to simplify other spider .inc files. Will sleep on it for a few days just in case.
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.10 [ 27530 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.0 [ 28320 ]
          Fix Version/s 11.1 [ 28549 ]
          Fix Version/s 11.2 [ 28603 ]
          ycp Yuchen Pei made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          ycp Yuchen Pei added a comment -

          Hi holyfoot, ptal thanks:

          https://github.com/MariaDB/server/commit/2973d6b1b9a

          ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks: https://github.com/MariaDB/server/commit/2973d6b1b9a
          ycp Yuchen Pei made changes -
          Assignee Yuchen Pei [ JIRAUSER52627 ] Alexey Botchkov [ holyfoot ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          holyfoot Alexey Botchkov added a comment -

          looks ok to push.

          holyfoot Alexey Botchkov added a comment - looks ok to push.
          holyfoot Alexey Botchkov made changes -
          Assignee Alexey Botchkov [ holyfoot ] Yuchen Pei [ JIRAUSER52627 ]
          Status In Review [ 10002 ] Stalled [ 10000 ]
          ycp Yuchen Pei added a comment - - edited

          Thanks for the review holyfoot.

          Pushed b6773f58196d74e0a0be83b4499fcb82799e1144 to 10.4, and merged into 10.5.
          Tested 10.4-11.2, ES-10.4,10.6,23.08. Conflicts and resolutions:

          • 10.4->10.5: aa9dd3d22483899375f8eb477458053a650115b7 drop s_1 too
          • 10.6->10.10: 73ddb5f37a39949bd927eda726605793764c5343 mtrec spider/bugfix.index
          ycp Yuchen Pei added a comment - - edited Thanks for the review holyfoot . Pushed b6773f58196d74e0a0be83b4499fcb82799e1144 to 10.4, and merged into 10.5. Tested 10.4-11.2, ES-10.4,10.6,23.08. Conflicts and resolutions: 10.4->10.5: aa9dd3d22483899375f8eb477458053a650115b7 drop s_1 too 10.6->10.10: 73ddb5f37a39949bd927eda726605793764c5343 mtrec spider/bugfix.index
          ycp Yuchen Pei made changes -
          Fix Version/s 10.4.32 [ 29300 ]
          Fix Version/s 10.5.23 [ 29012 ]
          Fix Version/s 10.6.16 [ 29014 ]
          Fix Version/s 10.10.7 [ 29018 ]
          Fix Version/s 10.11.6 [ 29020 ]
          Fix Version/s 11.0.4 [ 29021 ]
          Fix Version/s 11.1.3 [ 29023 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Fix Version/s 10.6 [ 24028 ]
          Fix Version/s 10.10 [ 27530 ]
          Fix Version/s 10.11 [ 27614 ]
          Fix Version/s 11.0 [ 28320 ]
          Fix Version/s 11.1 [ 28549 ]
          Fix Version/s 11.2 [ 28603 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]

          People

            ycp Yuchen Pei
            ycp Yuchen Pei
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.