Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31470

When set at runtime, wsrep_sst_method accepts any value

Details

    Description

      Invalid values are accepted:

      MariaDB [(none)]> set global wsrep_sst_method := 'handwrite rows and send them via post';
      		 
      Query OK, 0 rows affected (0.000 sec)
      		 
       
      		 
      MariaDB [(none)]> select @@wsrep_sst_method;
      		 
      +---------------------------------------+
      		 
      | @@wsrep_sst_method                    |
      		 
      +---------------------------------------+
      		 
      | handwrite rows and send them via post |
      		 
      +---------------------------------------+
      		 
      1 row in set (0.000 sec)

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23884 donor uses invalid SST methods

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Descending order - Click to sort in ascending order
            sysprg Julius Goryavsky added a comment -

            Fix merged with head revision: https://github.com/MariaDB/server/commit/c7feacb0dee696cf602a19da32d1069d0b0ff7c4

            sysprg Julius Goryavsky added a comment - Fix merged with head revision: https://github.com/MariaDB/server/commit/c7feacb0dee696cf602a19da32d1069d0b0ff7c4
            f_razzoli Federico Razzoli added a comment -

            The benefit is that the check will prevent mistakes.

            f_razzoli Federico Razzoli added a comment - The benefit is that the check will prevent mistakes.
            seppo Seppo Jaakola added a comment -

            a PR has been submitted to carry out same validity checks on wsrep_sst_method changing as what the donor node does for incoming SST request

            seppo Seppo Jaakola added a comment - a PR has been submitted to carry out same validity checks on wsrep_sst_method changing as what the donor node does for incoming SST request
            seppo Seppo Jaakola added a comment -

            wsep_sst_method is checked in donor node when SST request arrives. This is the proper location for enforcing the validity of the SST method, from the vulnerability point of view.

            It is also possible to check the wsrep_sst_method whenever the variable is changed and restrict accepted values in similar way as happens in donor processing. This has no other effect though, but stop the super user experimenting with this variable.

            seppo Seppo Jaakola added a comment - wsep_sst_method is checked in donor node when SST request arrives. This is the proper location for enforcing the validity of the SST method, from the vulnerability point of view. It is also possible to check the wsrep_sst_method whenever the variable is changed and restrict accepted values in similar way as happens in donor processing. This has no other effect though, but stop the super user experimenting with this variable.
            danblack Daniel Black added a comment -

            Well spotted.

            Like your example method too. Need more fun things in bug reports

            danblack Daniel Black added a comment - Well spotted. Like your example method too. Need more fun things in bug reports

            People

              sysprg Julius Goryavsky
              f_razzoli Federico Razzoli
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.