The review is taking place on the mailing list. Unfortunately the original message is nowhere to be found probably due to the mailing list migration. But my reply (and hopefully further replies) can be found at https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/IQKT52MKQCNQXODD2GV7GKEEVEFYYP6H/

Thanks for the comments. Updated commit for review at

https://github.com/MariaDB/server/commit/534031b77e0

Thanks for the 3rd round comments - ptal the updated patch thanks:

https://github.com/MariaDB/server/commit/e5cafa4e265

https://github.com/MariaDB/server/commit/e5cafa4e265 looks good, thanks. ok to push.

you might want to create a helper

static void print_init_failed_error(st_plugin_int *p)

{

  sql_print_error("Plugin '%s' registration as a %s failed.",

                  p->name.str,

                  plugin_type_names[p->plugin->type].str);

}

simply to make sure the error message in both cases is the same and those strings won't go out of sync

Thanks for the review serg, I'm pushing 734583b0d72 to 10.4, with the following conflict notes in the code:

/* [remove after merge] notes on merge conflict (MDEV-31400):
10.5: 81cd93bbb81d75e7cf14dedede0c9ec0712ace68
10.6-10.11: 13ba00ff4933cfc1712676f323587504e453d1b5
11.0-11.2: 42f8be10f18163c4025710cf6a212e82bddb2f62
The 10.11->11.0 conflict is trivial, but the reference commit also
contains different non-conflict changes needs to be applied to 11.0
(and beyond).
*/

Will close the ticket after it is pushed.