Setting the fix version to 11.2 provisionally. But if this task is needed to fix the spider init bugs existing in 10.5+ then so should this task cover these versions.

For this task, let's implement a simplified version as proposed in a comment in MDEV-22979[1], that is, initialise all the plugins, then initialise the ones that failed to initialise, and repeat the process until the list of remaining plugins do not decrease. If there are no cycles, this will eventually finish with 0 remaining plugins.

[1] https://jira.mariadb.org/browse/MDEV-22979?focusedCommentId=260463&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-260463

Since this task is considered as a solution for the spider init bugs like MDEV-22979 which exist in 10.4+, I am changing the fixversion of the present ticket accordingly.

A PoC patch:

https://github.com/MariaDB/server/commit/0e68e51a2db

Hi serg, PTAL thanks:

https://github.com/MariaDB/server/commit/a2e71bc8e89

Initially (e.g. in the PoC patch) I had the patch separated from the patch to fix spider init bugs, but then I was not sure how to test it without spider, so now these patched are merged together.

Hi serg, ptal thanks

https://github.com/MariaDB/server/commit/8b5de389ab1

The review is taking place on the mailing list. Unfortunately the original message is nowhere to be found probably due to the mailing list migration. But my reply (and hopefully further replies) can be found at https://lists.mariadb.org/hyperkitty/list/developers@lists.mariadb.org/thread/IQKT52MKQCNQXODD2GV7GKEEVEFYYP6H/

Thanks for the comments. Updated commit for review at

https://github.com/MariaDB/server/commit/534031b77e0

Thanks for the 3rd round comments - ptal the updated patch thanks:

https://github.com/MariaDB/server/commit/e5cafa4e265

https://github.com/MariaDB/server/commit/e5cafa4e265 looks good, thanks. ok to push.

you might want to create a helper

static void print_init_failed_error(st_plugin_int *p)

{

  sql_print_error("Plugin '%s' registration as a %s failed.",

                  p->name.str,

                  plugin_type_names[p->plugin->type].str);

}

simply to make sure the error message in both cases is the same and those strings won't go out of sync

Thanks for the review serg, I'm pushing 734583b0d72 to 10.4, with the following conflict notes in the code:

/* [remove after merge] notes on merge conflict (MDEV-31400):
10.5: 81cd93bbb81d75e7cf14dedede0c9ec0712ace68
10.6-10.11: 13ba00ff4933cfc1712676f323587504e453d1b5
11.0-11.2: 42f8be10f18163c4025710cf6a212e82bddb2f62
The 10.11->11.0 conflict is trivial, but the reference commit also
contains different non-conflict changes needs to be applied to 11.0
(and beyond).
*/

Will close the ticket after it is pushed.