Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-31146

Spider: Remove table options by COMMENT

Details

    Description

      MDEV-28861 deprecates the engine-defined options corresponding to major table options. So, we now can remove the table options, specified by COMMENT and CONNECTION, which have engine-defined option correspondence. Also, remove non-major, rarely used table options.

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. MDEV-28861 Spider: Deprecate table options by COMMENT

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-27106 Spider: specify connection to data node by engine-defined attributes

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            ralf.gebhardt Ralf Gebhardt created issue -
            ralf.gebhardt Ralf Gebhardt made changes -
            Field Original Value New Value
            Description MDEV-28856 implements the engine-defined options corresponding to major table options. So, we now deprecate the table options, specified by COMMENT, which have engine-defined option correspondence. Also, deprecate non-major, rarely used table options. MDEV-28861 deprecates the engine-defined options corresponding to major table options. So, we now can remove the table options, specified by COMMENT, which have engine-defined option correspondence. Also, remove non-major, rarely used table options.
            ralf.gebhardt Ralf Gebhardt made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Assignee Nayuta Yanagisawa [ JIRAUSER47117 ] Yuchen Pei [ JIRAUSER52627 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            serg Sergei Golubchik added a comment - - edited

            I suggest this to be done in steps:

            1. COMMENT is accepted, but SHOW CREATE TABLE shows options from MDEV-28861
            2. COMMENT causes a deprecation warning
            3. COMMENT is no longer parsed (after a some grace period after 2)

            I'm afraid there's no proper way of implementing 1, so either we skip it or it'll be some kind of a hack (luckily, it's needed only temporarily, until 3)

            serg Sergei Golubchik added a comment - - edited I suggest this to be done in steps: COMMENT is accepted, but SHOW CREATE TABLE shows options from MDEV-28861 COMMENT causes a deprecation warning COMMENT is no longer parsed (after a some grace period after 2) I'm afraid there's no proper way of implementing 1, so either we skip it or it'll be some kind of a hack (luckily, it's needed only temporarily, until 3)
            ycp Yuchen Pei made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            Description MDEV-28861 deprecates the engine-defined options corresponding to major table options. So, we now can remove the table options, specified by COMMENT, which have engine-defined option correspondence. Also, remove non-major, rarely used table options. MDEV-28861 deprecates the engine-defined options corresponding to major table options. So, we now can remove the table options, specified by COMMENT and CONNECTION, which have engine-defined option correspondence. Also, remove non-major, rarely used table options.
            serg Sergei Golubchik made changes -
            Fix Version/s 11.4 [ 29301 ]
            Fix Version/s 11.3 [ 28565 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 11.5 [ 29506 ]
            Fix Version/s 11.4 [ 29301 ]
            ycp Yuchen Pei made changes -
            Fix Version/s 11.6 [ 29515 ]
            Fix Version/s 11.5 [ 29506 ]
            julien.fritsch Julien Fritsch made changes -
            Issue Type Task [ 3 ] New Feature [ 2 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Issue Type New Feature [ 2 ] Task [ 3 ]
            ycp Yuchen Pei added a comment -

            Last I checked, the deprecation rule said: a feature should not be deleted until it's deprecated in all maintained versions.

            Since table options by COMMENT was deprecated for 11.4 (MDEV-28861), we have to wait for all versions < 11.4 to EOL, which means this ticket needs to wait till 2028 (10.11 EOL). So I guess we'll just keep bumping the fixversion till then...

            ycp Yuchen Pei added a comment - Last I checked, the deprecation rule said: a feature should not be deleted until it's deprecated in all maintained versions. Since table options by COMMENT was deprecated for 11.4 ( MDEV-28861 ), we have to wait for all versions < 11.4 to EOL, which means this ticket needs to wait till 2028 (10.11 EOL). So I guess we'll just keep bumping the fixversion till then...
            ycp Yuchen Pei made changes -
            Fix Version/s 11.7 [ 29815 ]
            Fix Version/s 11.6 [ 29515 ]
            ycp Yuchen Pei made changes -
            ycp Yuchen Pei made changes -
            Fix Version/s 11.7 [ 29815 ]

            People

              ycp Yuchen Pei
              ralf.gebhardt Ralf Gebhardt
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.