Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30545

Remove innodb_defragment and related parameters

Details

    Description

      The following parameters that were deprecated in MDEV-30544 will be removed:

      • innodb_defragment
      • innodb_defragment_n_pages
      • innodb_defragment_stats_accuracy
      • innodb_defragment_fill_factor_n_recs
      • innodb_defragment_fill_factor
      • innodb_defragment_frequency

      The related changes to OPTIMIZE TABLE in InnoDB will be removed as well. The parameter innodb_optimize_fulltext_only will retain its special meaning in OPTIMIZE TABLE.

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. MDEV-30544 Deprecate innodb_defragment and related parameters

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is caused by

          Task - A task that needs to be done. MDEV-5834 Merge Kakao Defragmentation implementation to MariaDB 10.1

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-18385 Document use cases and locking behavior for OPTIMIZE TABLE with innodb_defragment=1

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28558 The MTR based test innodb_defrag_concurrent is not repeatable.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä added a comment -

            This will fix one error that was caught by MDEV-24402:

            10.8 0751bfbcaf08c7c32de8d90b41b6c50ab525da6f

            		 
            CURRENT_TEST: innodb.innodb_defrag_concurrent
            		 
            --- /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.result	2022-12-05 04:16:31.000000000 +0000
            		 
            +++ /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.reject	2022-12-05 04:41:33.845583397 +0000
            		 
            @@ -77,6 +77,7 @@
            		 
             test.t1	optimize	status	OK
            		 
             check table t1 extended;
            		 
             Table	Op	Msg_type	Msg_text
            		 
            +test.t1	check	Warning	InnoDB: Unpurged clustered index record in table `test`.`t1`: COMPACT RECORD(info_bits=32, 8 fields): {[4]    (0x80000001),[6]      (0x00000000F4BA),[7]p      (0x70000002AB0EEA),[256]AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA(0x414141414141414141414141414141414141414141414141414141414141414141414
            		 
             test.t1	check	status	OK
            		 
             select count(*) from t1;
            		 
             count(*)

            I just caught that error locally on a 10.6-based branch.

            marko Marko Mäkelä added a comment - This will fix one error that was caught by MDEV-24402 : 10.8 0751bfbcaf08c7c32de8d90b41b6c50ab525da6f CURRENT_TEST: innodb.innodb_defrag_concurrent --- /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.result 2022-12-05 04:16:31.000000000 +0000 +++ /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.reject 2022-12-05 04:41:33.845583397 +0000 @@ -77,6 +77,7 @@ test.t1 optimize status OK check table t1 extended; Table Op Msg_type Msg_text +test.t1 check Warning InnoDB: Unpurged clustered index record in table `test`.`t1`: COMPACT RECORD(info_bits=32, 8 fields): {[4] (0x80000001),[6] (0x00000000F4BA),[7]p (0x70000002AB0EEA),[256]AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA(0x414141414141414141414141414141414141414141414141414141414141414141414 test.t1 check status OK select count(*) from t1; count(*) I just caught that error locally on a 10.6-based branch.
            mleich Matthias Leich added a comment - 

            The tree
            		 
            origin/bb-11.1-MDEV-30545 e1e007f9fbb0538b05a3f3b3e2ad8eb94a14391b 2023-03-06T16:47:24+02:00
            		 
            behaved well during RQG testing.
            		 
            The problems met are already known and in the main tree too.

            mleich Matthias Leich added a comment - The tree origin/bb-11.1-MDEV-30545 e1e007f9fbb0538b05a3f3b3e2ad8eb94a14391b 2023-03-06T16:47:24+02:00 behaved well during RQG testing. The problems met are already known and in the main tree too.

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.