[MDEV-30545] Remove innodb_defragment and related parameters Created: 2023-02-02  Updated: 2023-03-21  Resolved: 2023-03-11

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB
Fix Version/s: 11.1.0

Type: Task Priority: Blocker
Reporter: Marko Mäkelä Assignee: Marko Mäkelä
Resolution: Fixed Votes: 0
Labels: Preview_11.1

Issue Links:
Blocks
is blocked by MDEV-30544 Deprecate innodb_defragment and relat... Closed
Problem/Incident
is caused by MDEV-5834 Merge Kakao Defragmentation implement... Closed
Relates
relates to MDEV-18385 Document use cases and locking behavi... Open
relates to MDEV-28558 The MTR based test innodb_defrag_conc... Closed

 Description   

The following parameters that were deprecated in MDEV-30544 will be removed:

  • innodb_defragment
  • innodb_defragment_n_pages
  • innodb_defragment_stats_accuracy
  • innodb_defragment_fill_factor_n_recs
  • innodb_defragment_fill_factor
  • innodb_defragment_frequency

The related changes to OPTIMIZE TABLE in InnoDB will be removed as well. The parameter innodb_optimize_fulltext_only will retain its special meaning in OPTIMIZE TABLE.



 Comments   
Comment by Marko Mäkelä [ 2023-03-07 ]

This will fix one error that was caught by MDEV-24402:

10.8 0751bfbcaf08c7c32de8d90b41b6c50ab525da6f

CURRENT_TEST: innodb.innodb_defrag_concurrent
--- /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.result	2022-12-05 04:16:31.000000000 +0000
+++ /home/jenkins/workspace/Source-Build-Test/src/mysql-test/suite/innodb/r/innodb_defrag_concurrent.reject	2022-12-05 04:41:33.845583397 +0000
@@ -77,6 +77,7 @@
 test.t1	optimize	status	OK
 check table t1 extended;
 Table	Op	Msg_type	Msg_text
+test.t1	check	Warning	InnoDB: Unpurged clustered index record in table `test`.`t1`: COMPACT RECORD(info_bits=32, 8 fields): {[4]    (0x80000001),[6]      (0x00000000F4BA),[7]p      (0x70000002AB0EEA),[256]AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA(0x414141414141414141414141414141414141414141414141414141414141414141414
 test.t1	check	status	OK
 select count(*) from t1;
 count(*)

I just caught that error locally on a 10.6-based branch.

Comment by Matthias Leich [ 2023-03-09 ]

The tree
origin/bb-11.1-MDEV-30545 e1e007f9fbb0538b05a3f3b3e2ad8eb94a14391b 2023-03-06T16:47:24+02:00
behaved well during RQG testing.
The problems met are already known and in the main tree too.

Generated at Thu Feb 08 10:17:03 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.