Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30189

Add remaining mariadbd replication command line options as system variables

Details

    Description

      After MDEV-30188 and MDEV-15530, the remaining mariadbd command-line options that need to be converted to system variables are

      • master-info-file
      • master-retry-count
      • replicate-same-server-id
      • show-slave-auth-info
      • skip-slave-start

      For the variables which need name updates to be conventional with the primary/replica terminology (MDEV-18264), the new system variables should use the new primary/replica terminology, and aliases should be added for the command-line options.
      collapsed to MDEV-20602

      Attachments

        Issue Links

          includes

          New Feature - A new feature of the product, which has yet to be developed. MDEV-25674 No SQL variable for master_retry_count setting

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-27669 Not possible to check whether a server was started with skip-slave-start option

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          split from

          Task - A task that needs to be done. MDEV-28672 Several server options / settings still not visible from SQL level

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            View 11 older comments
            ParadoxV5 Jimmy Hú added a comment - - edited

            :shrug: multi-master.info is master.info with a hard-coded multi- prefix. In multi-source, the master.info file remains in use for the blank-named connection.

            A master_info_file field in SHOW REPLICA STATUS? +1.

            ParadoxV5 Jimmy Hú added a comment - - edited :shrug: multi-master.info is master.info with a hard-coded multi- prefix. In multi-source, the master.info file remains in use for the blank-named connection. A master_info_file field in SHOW REPLICA STATUS? +1.
            susil.behera Susil Behera added a comment -

            A master_info_file field in SHOW REPLICA STATUS?
            Makes sense to me. +1

            susil.behera Susil Behera added a comment - A master_info_file field in SHOW REPLICA STATUS? Makes sense to me. +1
            susil.behera Susil Behera added a comment -

            Verified the new SQL variables as follows,
            verified the following statemetns for both default and non-default values
            SELECT @@master_info_file; --PASS
            SELECT @@session.master_info_file; --ERROR
            SELECT @@global.master_info_file; --PASS
            SHOW VARIABLES LIKE 'master_info_file'; --ERROR
            SHOW VARIABLES LIKE '%master_info_%'; --ERROR

            SET master_info_file = 'new_master.info'; --ERROR
            SET @@master_info_file = 'new_master.info'; --ERROR
            SET @@session.master_info_file = 'new_master.info'; --ERROR
            SET @@global.master_info_file = 'new_master.info'; --ERROR
            SET @@local.master_info_file = 'new_master.info';
            SET LOCAL master_info_file = 'new_master.info'; --ERROR
            SET @x = 1, master_info_file = 'new_master.info'; --ERROR
            SET @x = 1, @@master_info_file = 'new_master.info'; --ERROR
            SET @x = 1, @@session.master_info_file = 'new_master.info'; --ERROR
            SET @x = 1, @@global.master_info_file = 'new_master.info'; --ERROR

            Looks good.

            susil.behera Susil Behera added a comment - Verified the new SQL variables as follows, verified the following statemetns for both default and non-default values SELECT @@master_info_file; --PASS SELECT @@session.master_info_file; --ERROR SELECT @@global.master_info_file; --PASS SHOW VARIABLES LIKE 'master_info_file'; --ERROR SHOW VARIABLES LIKE '%master_info_%'; --ERROR SET master_info_file = 'new_master.info'; --ERROR SET @@master_info_file = 'new_master.info'; --ERROR SET @@session.master_info_file = 'new_master.info'; --ERROR SET @@global.master_info_file = 'new_master.info'; --ERROR SET @@local.master_info_file = 'new_master.info'; SET LOCAL master_info_file = 'new_master.info'; --ERROR SET @x = 1, master_info_file = 'new_master.info'; --ERROR SET @x = 1, @@master_info_file = 'new_master.info'; --ERROR SET @x = 1, @@session.master_info_file = 'new_master.info'; --ERROR SET @x = 1, @@global.master_info_file = 'new_master.info'; --ERROR Looks good.
            susil.behera Susil Behera added a comment -

            OK to push from QA.

            susil.behera Susil Behera added a comment - OK to push from QA.
            bnestere Brandon Nesterenko added a comment - - edited

            Pushed into main (12.0) as c29e83f2261

            Release Notes:

            Command-line options --master-info-file, --replicate-same-server-id and --show-slave-auth-info are now available as read-only system variables.

            bnestere Brandon Nesterenko added a comment - - edited Pushed into main (12.0) as c29e83f2261 Release Notes: Command-line options --master-info-file , --replicate-same-server-id and --show-slave-auth-info are now available as read-only system variables.

            People

              ParadoxV5 Jimmy Hú
              bnestere Brandon Nesterenko
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.