Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30182

Optimize open_tables to take O(N) time

    XMLWordPrintable

Details

    • Task
    • Status: In Review (View Workflow)
    • Major
    • Resolution: Unresolved
    • 11.9
    • None
    • None

    Description

      See also MDEV-22180 and MDEV-30103 (comment).

      find_fk_prelocked_table traverses all opened tables in connection, MDL_context::find_ticket traverses all mdl tickets which is also not less amount of steps. Both functions are called for each table, taking O(tables^2) time total, during opening tables.

      Opening a table for an operation like UPDATE or DELETE for a table with 12k child tables takes about 3.5 seconds on my laptop. Making the two mentioned fuinctions noop takes 0.15 seconds.

      What should be done

      A list traversal should be changed to a hash lookup when a number of tables to open is big.
      Hashing is an expensive operation, so for a smaller number of tables (an exact value is to be determined) it should be left as a list traversal.

      We can't predict an exact number of tables to open preliminarily: it grows dynamically, once the tables are opened (and triggers/FK relations are checked), so we need a data structure which will also dynamically adapt.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29181 Potential corruption on Foreign key update on a table with vcol index

          • Major - Major loss of function.
          • Stalled

          Task - A task that needs to be done. MDEV-31654 Support STORED generated columns with FK cascade changes

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31931 FK fields cannot be used anymore in generated columns

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-31942 Online alter: support cascade foreign keys

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22180 Planner opens unnecessary tables when updated table is referenced by foreign keys

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-29181 Potential corruption on Foreign key update on a table with vcol index

          • Major - Major loss of function.
          • Stalled

          Activity

            People

              wlad Vladislav Vaintroub
              nikitamalyavin Nikita Malyavin
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.