Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-30170

no error for DROP TABLE and no warning for DROP TABLE IF EXISTS with absent table when Spider plugin is included

Details

    • 2022-22

    Description

      Tested with 10.6.11-6-MariaDB server,
      rocky linux 8 (also seen at several more RPM-linuxes),
      only if spider plugin is enabled during MariaDB server build (cmake -DPLUGIN_SPIDER=YES).

      Use any database and any non-existing table name.

      DROP TABLE non_existing_table;

      • should be:
        ERROR 42S02: Unknown table 'auto_test_local.non_existing_table'
      • actual:
        Query OK, 0 rows affected (0.005 sec)

      DROP TABLE IF EXISTS non_existing_table;

      • should be:
        Warnings: Note 1051 Unknown table 'non_existing_table'
      • actual:
        Query OK, 0 rows affected (0.005 sec)

      Attachments

        Issue Links

          is caused by

          Task - A task that needs to be done. MDEV-11412 Ensure that table is truly dropped when using DROP TABLE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32505 Spider: DROP TABLE succeeds where it should not

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova added a comment -

            Likely related to MDEV-22826 fix.

            elenst Elena Stepanova added a comment - Likely related to MDEV-22826 fix.
            ycp Yuchen Pei added a comment -

            We got a fresher ticket reporting the same problem: MDEV-32505

            ycp Yuchen Pei added a comment - We got a fresher ticket reporting the same problem: MDEV-32505
            ycp Yuchen Pei added a comment -

            Hi holyfoot, ptal thanks

            upstream/bb-10.5-mdev-30170 df43219e708ad554330a2ac06d7789eb7303a91b
            		 
            MDEV-30170 ha_spider::delete_table() should report table not exist
            		 
             
            		 
            All Spider tables are recorded in the system table
            		 
            mysql.spider_tables. Deleting a spider table removes the corresponding
            		 
            rows from the system table, among other things. This patch makes it so
            		 
            that if spider could not find any record in the system table to delete
            		 
            for a given table, it should correctly report that no such Spider
            		 
            table exists.

            For 11.0 see

            b3d6de943bf upstream/bb-11.0-mdev-30170 MDEV-30170 ha_spider::delete_table() should report table not exist

            ycp Yuchen Pei added a comment - Hi holyfoot , ptal thanks upstream/bb-10.5-mdev-30170 df43219e708ad554330a2ac06d7789eb7303a91b MDEV-30170 ha_spider::delete_table() should report table not exist   All Spider tables are recorded in the system table mysql.spider_tables. Deleting a spider table removes the corresponding rows from the system table, among other things. This patch makes it so that if spider could not find any record in the system table to delete for a given table, it should correctly report that no such Spider table exists. For 11.0 see b3d6de943bf upstream/bb-11.0-mdev-30170 MDEV-30170 ha_spider::delete_table() should report table not exist
            holyfoot Alexey Botchkov added a comment -

            ok to push.

            holyfoot Alexey Botchkov added a comment - ok to push.
            ycp Yuchen Pei added a comment -

            pushed 9e9e0b99ade0e6ccd34abc3bc3abaf7bbd5ecf4e to 10.5

            ycp Yuchen Pei added a comment - pushed 9e9e0b99ade0e6ccd34abc3bc3abaf7bbd5ecf4e to 10.5

            People

              ycp Yuchen Pei
              drrtuy Roman
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.