[MDEV-26322] Last binlog file and position are "empty" in mariabackup --prepare output - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.5.7, 10.5.9, 10.5.13, 10.5, 10.6
Fix Version/s: 10.5.16, 10.6.8, 10.7.4, 10.8.3, 10.9.1
Component/s: mariabackup
Labels:
- regression-10.5

Description

Normally (till 10.5.x) mariabackup prepare stage reports last binlog file and position at the end, for example:

openxs@ao756:~/dbs/maria10.4$  bin/mariabackup --no-defaults --binlog-info=on --prepare --target-dir=/tmp/backup

bin/mariabackup based on MariaDB server 10.4.22-MariaDB Linux (x86_64)

[00] 2021-08-08 16:46:12 cd to /tmp/backup/

[00] 2021-08-08 16:46:12 open files limit requested 0, set to 1024

[00] 2021-08-08 16:46:12 This target seems to be not prepared yet.

[00] 2021-08-08 16:46:12 mariabackup: using the following InnoDB configuration for recovery:

[00] 2021-08-08 16:46:12 innodb_data_home_dir = .

[00] 2021-08-08 16:46:12 innodb_data_file_path = ibdata1:10M:autoextend

[00] 2021-08-08 16:46:12 innodb_log_group_home_dir = .

[00] 2021-08-08 16:46:12 InnoDB: Using Linux native AIO

[00] 2021-08-08 16:46:12 Starting InnoDB instance for recovery.

[00] 2021-08-08 16:46:12 mariabackup: Using 104857600 bytes for buffer pool (set by --use-memory parameter)

2021-08-08 16:46:12 0 [Note] InnoDB: Mutexes and rw_locks use GCC atomic builtins

2021-08-08 16:46:12 0 [Note] InnoDB: Uses event mutexes

2021-08-08 16:46:12 0 [Note] InnoDB: Compressed tables use zlib 1.2.11

2021-08-08 16:46:12 0 [Note] InnoDB: Number of pools: 1

2021-08-08 16:46:12 0 [Note] InnoDB: Using SSE2 crc32 instructions

2021-08-08 16:46:12 0 [Note] InnoDB: Initializing buffer pool, total size = 100M, instances = 1, chunk size = 100M

2021-08-08 16:46:13 0 [Note] InnoDB: Completed initialization of buffer pool

2021-08-08 16:46:13 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().

2021-08-08 16:46:13 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=651139114

2021-08-08 16:46:15 0 [Note] InnoDB: Starting a batch to recover 291 pages from redo log.

2021-08-08 16:46:17 0 [Note] InnoDB: Starting final batch to recover 167 pages from redo log.

2021-08-08 16:46:17 0 [Note] InnoDB: Last binlog file './ao756-bin.000002', position 31344186

[00] 2021-08-08 16:46:18 Last binlog file ./ao756-bin.000002, position 31344186

[00] 2021-08-08 16:46:18 completed OK!

But in 10.5.x it's reported as "empty":

openxs@ao756:~/dbs/maria10.5$ bin/mariabackup --no-defaults --binlog-info=on --prepare --target-dir=/tmp/backup

bin/mariabackup based on MariaDB server 10.5.13-MariaDB Linux (x86_64)

[00] 2021-08-08 14:58:54 cd to /tmp/backup/

[00] 2021-08-08 14:58:54 open files limit requested 0, set to 1024

[00] 2021-08-08 14:58:54 This target seems to be not prepared yet.

[00] 2021-08-08 14:58:54 mariabackup: using the following InnoDB configuration for recovery:

[00] 2021-08-08 14:58:54 innodb_data_home_dir = .

[00] 2021-08-08 14:58:54 innodb_data_file_path = ibdata1:10M:autoextend

[00] 2021-08-08 14:58:54 innodb_log_group_home_dir = .

[00] 2021-08-08 14:58:54 InnoDB: Using Linux native AIO

[00] 2021-08-08 14:58:54 Starting InnoDB instance for recovery.

[00] 2021-08-08 14:58:54 mariabackup: Using 104857600 bytes for buffer pool (set by --use-memory parameter)

2021-08-08 14:58:54 0 [Note] InnoDB: Uses event mutexes

2021-08-08 14:58:54 0 [Note] InnoDB: Compressed tables use zlib 1.2.11

2021-08-08 14:58:54 0 [Note] InnoDB: Number of pools: 1

2021-08-08 14:58:54 0 [Note] InnoDB: Using crc32 + pclmulqdq instructions

2021-08-08 14:58:54 0 [Note] InnoDB: Using Linux native AIO

2021-08-08 14:58:54 0 [Note] InnoDB: Initializing buffer pool, total size = 104857600, chunk size = 104857600

2021-08-08 14:58:54 0 [Note] InnoDB: Completed initialization of buffer pool

2021-08-08 14:58:55 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=1050962794,1120684838

2021-08-08 14:59:00 0 [Note] InnoDB: Starting a batch to recover 155 pages from redo log.

2021-08-08 14:59:02 0 [Note] InnoDB: Starting a batch to recover 155 pages from redo log.

2021-08-08 14:59:04 0 [Note] InnoDB: Starting a batch to recover 157 pages from redo log.

2021-08-08 14:59:06 0 [Note] InnoDB: Starting a batch to recover 162 pages from redo log.

2021-08-08 14:59:07 0 [Note] InnoDB: Starting final batch to recover 358 pages from redo log.

[00] 2021-08-08 14:59:08 Last binlog file , position 0

[00] 2021-08-08 14:59:08 completed OK!

It looks like a regression bug, but maybe there is a good reason NOT to report it (where is it documented then?) In the latter case why this output appears at the log at all? It adds no value, just a confusion.

See also MDEV-21611 and related bugs there. Cross checking vs the information reported at --backup stage and xtrabackup_binlog_info is important for troubleshooting in some cases.

Attachments

Issue Links

relates to

MDEV-12353 Efficient InnoDB redo log record format

Closed

MDEV-21174 Refactor mlog_write_ulint, mlog_memset, mlog_write_string

Closed

MDEV-22351 InnoDB may report incorrect binlog position information after RESET MASTER

Closed

Activity

Ascending order - Click to sort in descending order

Valerii Kravchuk created issue - 2021-08-09 08:59

Julien Fritsch made changes - 2021-08-26 14:38

Field	Original Value	New Value
Assignee		Marko Mäkelä [ marko ]

Marko Mäkelä made changes - 2021-08-26 15:55

Link

This issue relates to ~~MDEV-21174~~ [ ~~MDEV-21174~~ ]

Marko Mäkelä made changes - 2021-08-26 15:55

Link

This issue relates to ~~MDEV-12353~~ [ ~~MDEV-12353~~ ]

Marko Mäkelä made changes - 2021-08-26 16:08

Assignee

Marko Mäkelä [ marko ]

Alice Sherepa [ alice ]

Julien Fritsch made changes - 2021-08-27 06:53

Fix Version/s

10.5 [ 23123 ]

Alice Sherepa made changes - 2021-09-03 11:33

Assignee

Alice Sherepa [ alice ]

Marko Mäkelä [ marko ]

Alice Sherepa made changes - 2021-09-03 11:33

Affects Version/s		10.5 [ 23123 ]
Affects Version/s		10.6 [ 24028 ]

Alice Sherepa made changes - 2021-09-03 11:33

Fix Version/s

10.6 [ 24028 ]

Marko Mäkelä made changes - 2021-09-03 12:21

Link

This issue relates to ~~MDEV-22351~~ [ ~~MDEV-22351~~ ]

Marko Mäkelä made changes - 2021-09-03 12:21

Affects Version/s		10.5.7 [ 25019 ]
Assignee	Marko Mäkelä [ marko ]	Vladislav Lesin [ vlad.lesin ]
Labels		regression-10.5

Marko Mäkelä made changes - 2021-09-03 12:22

Status

Open [ 1 ]

Confirmed [ 10101 ]

Julien Fritsch made changes - 2021-12-06 08:46

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Golubchik made changes - 2021-12-06 21:36

Workflow

MariaDB v3 [ 124161 ]

MariaDB v4 [ 144390 ]

Vladislav Lesin made changes - 2022-03-30 11:20

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Vladislav Lesin made changes - 2022-03-31 14:53

Comment

[ 59a0236da48 reverting does not make sense, because the function, which writes binlog position(trx_sys_update_mysql_binlog_offset()) in rseg header was removed in 10.3.5. I also did not find any writes with TRX_SYS_MYSQL_LOG_OFFSET offsets in 10.3.5. The function was removed in the following merging commit: 2732fcc608e Merge branch 'bb-10.2-ext' into 10.3. So the fix is to remove the corresponding message output from mariabackup, and the corresponding code from InnoDB, because trx_sys_update_mysql_binlog_offset() removing was not clean, and unused code left after the removing. ]

Vladislav Lesin made changes - 2022-04-05 06:14

Fix Version/s		10.5.16 [ 27508 ]
Fix Version/s		10.6.8 [ 27506 ]
Fix Version/s		10.7.4 [ 27504 ]
Fix Version/s		10.8.3 [ 27502 ]
Fix Version/s		10.9.1 [ 27114 ]
Fix Version/s	10.5 [ 23123 ]
Fix Version/s	10.6 [ 24028 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Jira Automation (IT) made changes - 2024-07-04 02:22

Zendesk Related Tickets

132681

People

Assignee:: Vladislav Lesin

Reporter:: Valerii Kravchuk

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2021-08-09 08:59

Updated:: 2024-07-07 21:16

Resolved:: 2022-04-05 06:14

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration