Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25973

Fix tests that were temporary disabled in PS mode

Details

    Description

      This is a follow-up task for MDEV-16708.

      List of tests that were disabled by MDEV-16708 for running in PS mode is below:

      main.cte_recursive
      main.features
      main.fetch_first
      main.func_group
      main.limit_rows_examined
      main.opt_trace
      main.parser_stack
      main.sp-row
      compat/oracle.sp-row
      funcs_1.storedproc
      plugins.test_sql_service
      rpl.rpl_gtid_stop_start
      sys_vars.stored_program_cache_func
      versioning.cte
      versioning.select

      The goal of this task is to address all issues preventing disabled tests to be run in PS mode.

      Attachments

        Issue Links

          is blocked by

          Technical task - A technical task. MDEV-26135 Assertion failure when executing PS with a hanging recursive CTE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26142 Fix failures of the tests main.features and sys_vars.stored_program_cache_func when they are run in PS mode

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26145 Incorrect metadata is sent on running query with union in PS mode

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26146 The test main.limit_rows_examined fails in case it is run in PS mode.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26147 The test main.sp-row fails in case it is run in PS mode

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26149 The test main.fetch_first fails in case it is run in PS mode

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26150 The test main.opt_trace fails in case it is run in PS mode

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Technical task - A technical task. MDEV-26181 The test compat/oracle.sp-row fails in case it is run in PS mode.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-26189 Missing handling of unknown column in WHERE of recursive CTE

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            shulga Dmitry Shulga added a comment -

            The tests rpl.rpl_events, rpl.rpl_bug31076 were removed from the original list of failing tests to fix since
            these tests contain use cases that run multi-statements (Multi-statements are not supported by PS protocol).

            The test rpl.rpl_events contains the following multi-statements test case 

            DELIMITER |;
            		 
            CREATE /*!50000 DEFINER='user44331' */ EVENT event44331_4
            		 
              ON SCHEDULE AT CURRENT_TIMESTAMP
            		 
              ON COMPLETION PRESERVE DISABLE
            		 
              DO INSERT INTO test.t1 VALUES('event event44331_4 fired - DEFINER=user1');
            		 
            # Test for bug#50095 Multi-statement including CREATE EVENT causes rotten
            		 
            # binlog entry
            		 
              SELECT 'ABC';
            		 
              SELECT '123'|
            		 
            DELIMITER ;|

            The test rpl.rpl_bug31076 contains the following lines that breaks the rule 'no multi-line statements in PS mode'. 

            /*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=0*/;
            		 
            use track/*!*/;

            For the above test case the statements delimiter is set as
            --delimiter /!/;

            shulga Dmitry Shulga added a comment - The tests rpl.rpl_events, rpl.rpl_bug31076 were removed from the original list of failing tests to fix since these tests contain use cases that run multi-statements (Multi-statements are not supported by PS protocol). The test rpl.rpl_events contains the following multi-statements test case DELIMITER |; CREATE /*!50000 DEFINER='user44331' */ EVENT event44331_4 ON SCHEDULE AT CURRENT_TIMESTAMP ON COMPLETION PRESERVE DISABLE DO INSERT INTO test.t1 VALUES ( 'event event44331_4 fired - DEFINER=user1' ); # Test for bug#50095 Multi-statement including CREATE EVENT causes rotten # binlog entry SELECT 'ABC' ; SELECT '123' | DELIMITER ;| The test rpl.rpl_bug31076 contains the following lines that breaks the rule 'no multi-line statements in PS mode'. /*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=0*/; use track/*!*/; For the above test case the statements delimiter is set as --delimiter / ! /;

            People

              shulga Dmitry Shulga
              shulga Dmitry Shulga
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.