[MDEV-25973] Fix tests that were temporary disabled in PS mode Created: 2021-06-21  Updated: 2023-12-12

Status: Stalled
Project: MariaDB Server
Component/s: Prepared Statements
Affects Version/s: 10.6.2
Fix Version/s: 10.6, 10.11

Type: Bug Priority: Major
Reporter: Dmitry Shulga Assignee: Dmitry Shulga
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Blocks
is blocked by MDEV-26135 Assertion failure when executing PS w... Closed
is blocked by MDEV-26142 Fix failures of the tests main.featur... Closed
is blocked by MDEV-26145 Incorrect metadata is sent on running... Closed
is blocked by MDEV-26146 The test main.limit_rows_examined fai... Closed
is blocked by MDEV-26147 The test main.sp-row fails in case it... Closed
is blocked by MDEV-26149 The test main.fetch_first fails in ca... Closed
is blocked by MDEV-26150 The test main.opt_trace fails in case... Closed
is blocked by MDEV-26181 The test compat/oracle.sp-row fails i... Closed
is blocked by MDEV-26189 Missing handling of unknown column in... Closed
Sub-Tasks:
Key
 Summary
 Type
 Status
 Assignee
MDEV-26135 Assertion failure when executing PS w... Technical task Closed Igor Babaev  
MDEV-26142 Fix failures of the tests main.featur... Technical task Closed Dmitry Shulga  
MDEV-26145 Incorrect metadata is sent on running... Technical task Closed Dmitry Shulga  
MDEV-26146 The test main.limit_rows_examined fai... Technical task Closed Dmitry Shulga  
MDEV-26147 The test main.sp-row fails in case it... Technical task Closed Dmitry Shulga  
MDEV-26149 The test main.fetch_first fails in ca... Technical task Closed Dmitry Shulga  
MDEV-26150 The test main.opt_trace fails in case... Technical task Closed Dmitry Shulga  
MDEV-26181 The test compat/oracle.sp-row fails i... Technical task Closed Dmitry Shulga  
MDEV-26209 The test plugins.test_sql_service fai... Technical task Closed Dmitry Shulga  

 Description   

This is a follow-up task for MDEV-16708.

List of tests that were disabled by MDEV-16708 for running in PS mode is below:

main.cte_recursive
main.features
main.fetch_first
main.func_group
main.limit_rows_examined
main.opt_trace
main.parser_stack
main.sp-row
compat/oracle.sp-row
funcs_1.storedproc
plugins.test_sql_service
rpl.rpl_gtid_stop_start
sys_vars.stored_program_cache_func
versioning.cte
versioning.select

The goal of this task is to address all issues preventing disabled tests to be run in PS mode.

 Comments   
Comment by Dmitry Shulga [ 2021-06-27 ]

The tests rpl.rpl_events, rpl.rpl_bug31076 were removed from the original list of failing tests to fix since
these tests contain use cases that run multi-statements (Multi-statements are not supported by PS protocol).

The test rpl.rpl_events contains the following multi-statements test case 

DELIMITER |;
 
CREATE /*!50000 DEFINER='user44331' */ EVENT event44331_4
 
  ON SCHEDULE AT CURRENT_TIMESTAMP
 
  ON COMPLETION PRESERVE DISABLE
 
  DO INSERT INTO test.t1 VALUES('event event44331_4 fired - DEFINER=user1');
 
# Test for bug#50095 Multi-statement including CREATE EVENT causes rotten
 
# binlog entry
 
  SELECT 'ABC';
 
  SELECT '123'|
 
DELIMITER ;|

The test rpl.rpl_bug31076 contains the following lines that breaks the rule 'no multi-line statements in PS mode'. 

/*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=0*/;
 
use track/*!*/;

For the above test case the statements delimiter is set as
--delimiter /!/;

Generated at Thu Feb 08 09:41:47 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.