Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21301

mariabackup doesn't read [mariadb-backup] option group in configuration file

Details

    Description

      Since MDEV-17591, MariaDB has installed mariadb-backup as an alias for mariabackup. See here:

      https://github.com/MariaDB/server/blob/mariadb-10.4.11/cmake/symlinks.cmake#L15

      Similar aliases are installed for other commands. For example, mariadb-binlog is installed as an alias for mysqlbinlog. As part of this change, the mysqlbinlog utility now reads options from the [mariadb-binlog] option group as well. From client/mysqlbinlog.cc:

      static const char *load_groups[]=
      		 
      { "mysqlbinlog", "mariadb-binlog", "client", "client-server", "client-mariadb",
      		 
        0 };

      https://github.com/MariaDB/server/blob/mariadb-10.4.11/client/mysqlbinlog.cc#L96

      However, mariabackup does not yet read from the mariadb-backup option group. From extra/mariabackup/xtrabackup.cc:

      static const char *xb_client_default_groups[]={
      		 
         "xtrabackup", "mariabackup",
      		 
         "client", "client-server",
      		 
         "client-mariadb",
      		 
         0, 0, 0
      		 
      };
      		 
       
      		 
      static const char *xb_server_default_groups[]={
      		 
         "xtrabackup", "mariabackup",
      		 
         "mysqld", "server", MYSQL_BASE_VERSION,
      		 
         "mariadb", MARIADB_BASE_VERSION,
      		 
         "client-server",
      		 
         #ifdef WITH_WSREP
      		 
         "galera",
      		 
         #endif
      		 
         0, 0, 0
      		 
      };

      https://github.com/MariaDB/server/blob/mariadb-10.4.11/extra/mariabackup/xtrabackup.cc#L1570

      Also see the documentation:

      https://mariadb.com/kb/en/library/mariabackup-overview/#server-option-groups

      https://mariadb.com/kb/en/library/mariabackup-overview/#client-option-groups

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22894 Mariabackup should not read [mariadb-client] option group from configuration files

          • Major - Major loss of function.
          • Closed
          is caused by

          Task - A task that needs to be done. MDEV-17591 Create MariaDB named commands

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-14746 mariabackup doesn't read [mariabackup] option group in configuration file

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18215 mariabackup does not report unknown command line options

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-18347 mariabackup doesn't read all server option groups from configuration files

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21298 mariabackup doesn't read from the [mariadbd] and [mariadbd-X.Y] server option groups from configuration files

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-21303 Make executables MariaDB named

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            GeoffMontee Geoff Montee (Inactive) created issue -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Field Original Value New Value
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Description Since MDEV-17591, MariaDB has installed {{mariadb-backup}} as an alias for {{mariabackup}}. See here:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/cmake/symlinks.cmake#L15

            Similar aliases are installed for other commands. For example, {{mariadb-binlog}} is installed as an alias for {{mysqlbinlog}}. As part of this change, the {{mysqlbinlog}} utility now reads options from the {{[mariadb-binlog]}} option group as well. From {{client/mysqlbinlog.cc}}:

            {code}
            static const char *load_groups[]=
            { "mysqlbinlog", "mariadb-binlog", "client", "client-server", "client-mariadb",
              0 };
            {code}

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/client/mysqlbinlog.cc#L96

            However, {{mariabackup}} does not yet read from the {{mariadb-backup}} option group. From {{extra/mariabackup/xtrabackup.cc}}:

            {code}
            static const char *xb_client_default_groups[]={
               "xtrabackup", "mariabackup",
               "client", "client-server",
               "client-mariadb",
               0, 0, 0
            };

            static const char *xb_server_default_groups[]={
               "xtrabackup", "mariabackup",
               "mysqld", "server", MYSQL_BASE_VERSION,
               "mariadb", MARIADB_BASE_VERSION,
               "client-server",
               #ifdef WITH_WSREP
               "galera",
               #endif
               0, 0, 0
            };
            {code}

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/extra/mariabackup/xtrabackup.cc#L1570             		Since MDEV-17591, MariaDB has installed {{mariadb-backup}} as an alias for {{mariabackup}}. See here:

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/cmake/symlinks.cmake#L15

            Similar aliases are installed for other commands. For example, {{mariadb-binlog}} is installed as an alias for {{mysqlbinlog}}. As part of this change, the {{mysqlbinlog}} utility now reads options from the {{[mariadb-binlog]}} option group as well. From {{client/mysqlbinlog.cc}}:

            {code}
            static const char *load_groups[]=
            { "mysqlbinlog", "mariadb-binlog", "client", "client-server", "client-mariadb",
              0 };
            {code}

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/client/mysqlbinlog.cc#L96

            However, {{mariabackup}} does not yet read from the {{mariadb-backup}} option group. From {{extra/mariabackup/xtrabackup.cc}}:

            {code}
            static const char *xb_client_default_groups[]={
               "xtrabackup", "mariabackup",
               "client", "client-server",
               "client-mariadb",
               0, 0, 0
            };

            static const char *xb_server_default_groups[]={
               "xtrabackup", "mariabackup",
               "mysqld", "server", MYSQL_BASE_VERSION,
               "mariadb", MARIADB_BASE_VERSION,
               "client-server",
               #ifdef WITH_WSREP
               "galera",
               #endif
               0, 0, 0
            };
            {code}

            https://github.com/MariaDB/server/blob/mariadb-10.4.11/extra/mariabackup/xtrabackup.cc#L1570

            Also see the documentation:

            https://mariadb.com/kb/en/library/mariabackup-overview/#server-option-groups

            https://mariadb.com/kb/en/library/mariabackup-overview/#client-option-groups
            GeoffMontee Geoff Montee (Inactive) made changes -
            ratzpo Rasmus Johansson (Inactive) made changes -
            Assignee Vladislav Lesin [ vlad.lesin ] Rasmus Johansson [ ratzpo ]
            julien.fritsch Julien Fritsch made changes -
            Assignee Rasmus Johansson [ ratzpo ] Vladislav Lesin [ vlad.lesin ]
            vlad.lesin Vladislav Lesin made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            vlad.lesin Vladislav Lesin added a comment -

            The same code is changed during the work on MDEV-18215, so the fix on MDEV-21301 can be joined with MDEV-18215 fix.

            vlad.lesin Vladislav Lesin added a comment - The same code is changed during the work on MDEV-18215 , so the fix on MDEV-21301 can be joined with MDEV-18215 fix.
            vlad.lesin Vladislav Lesin made changes -
            vlad.lesin Vladislav Lesin made changes -
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.4.14 [ 24305 ]
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 101839 ] MariaDB v4 [ 157094 ]
            GeoffMontee Geoff Montee (Inactive) made changes -

            People

              vlad.lesin Vladislav Lesin
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.