[MDEV-21301] mariabackup doesn't read [mariadb-backup] option group in configuration file Created: 2019-12-12  Updated: 2022-03-24  Resolved: 2020-06-14

Status: Closed
Project: MariaDB Server
Component/s: Configuration, mariabackup
Affects Version/s: 10.4.11, 10.5.0
Fix Version/s: 10.5.4, 10.4.14

Type: Bug Priority: Major
Reporter: Geoff Montee (Inactive) Assignee: Vladislav Lesin
Resolution: Fixed Votes: 1
Labels: configuration, mariabackup, my.cnf

Issue Links:
Problem/Incident
causes MDEV-22894 Mariabackup should not read [mariadb-... Closed
is caused by MDEV-17591 Create MariaDB named commands Closed
Relates
relates to MDEV-14746 mariabackup doesn't read [mariabackup... Closed
relates to MDEV-18215 mariabackup does not report unknown c... Closed
relates to MDEV-18347 mariabackup doesn't read all server o... Closed
relates to MDEV-21298 mariabackup doesn't read from the [ma... Closed
relates to MDEV-21303 Make executables MariaDB named Closed

 Description   

Since MDEV-17591, MariaDB has installed mariadb-backup as an alias for mariabackup. See here:

https://github.com/MariaDB/server/blob/mariadb-10.4.11/cmake/symlinks.cmake#L15

Similar aliases are installed for other commands. For example, mariadb-binlog is installed as an alias for mysqlbinlog. As part of this change, the mysqlbinlog utility now reads options from the [mariadb-binlog] option group as well. From client/mysqlbinlog.cc:

static const char *load_groups[]=
 
{ "mysqlbinlog", "mariadb-binlog", "client", "client-server", "client-mariadb",
 
  0 };

https://github.com/MariaDB/server/blob/mariadb-10.4.11/client/mysqlbinlog.cc#L96

However, mariabackup does not yet read from the mariadb-backup option group. From extra/mariabackup/xtrabackup.cc:

static const char *xb_client_default_groups[]={
 
   "xtrabackup", "mariabackup",
 
   "client", "client-server",
 
   "client-mariadb",
 
   0, 0, 0
 
};
 
 
 
static const char *xb_server_default_groups[]={
 
   "xtrabackup", "mariabackup",
 
   "mysqld", "server", MYSQL_BASE_VERSION,
 
   "mariadb", MARIADB_BASE_VERSION,
 
   "client-server",
 
   #ifdef WITH_WSREP
 
   "galera",
 
   #endif
 
   0, 0, 0
 
};

https://github.com/MariaDB/server/blob/mariadb-10.4.11/extra/mariabackup/xtrabackup.cc#L1570

Also see the documentation:

https://mariadb.com/kb/en/library/mariabackup-overview/#server-option-groups

https://mariadb.com/kb/en/library/mariabackup-overview/#client-option-groups

 Comments   
Comment by Vladislav Lesin [ 2020-06-09 ]

The same code is changed during the work on MDEV-18215, so the fix on MDEV-21301 can be joined with MDEV-18215 fix.

Generated at Thu Feb 08 09:06:06 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.