[MDEV-20614] Syntax error, and option put in wrong place, in mysqld_multi perl script - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Blocker
Resolution: Fixed
Affects Version/s: 10.2.27, 10.3.18, 10.4.8
Fix Version/s: 10.2.28, 10.1.42, 10.3.19, 10.4.9
Component/s: Scripts & Clients
Labels:
None

Description

Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of elseif instead of perl elsif

The following one character change fixes this:

diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh

index b8730e2624a..748925bef0b 100644

--- a/scripts/mysqld_multi.sh

+++ b/scripts/mysqld_multi.sh

@@ -349,7 +349,7 @@ sub start_mysqlds()

         $options[$j]= quote_shell_word($options[$j]);

         $tmp.= " $options[$j]";

-      elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))

+      elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))

         $suffix_found= 1;

But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required.

The following should fix this for the default case, where mysqld in the [mysqld_multi] section is either given as mysqld or mysqld_multi, as expected. It will fail though if mysqld setting already contains a command line setting by itself ...

@@ -368,7 +368,6 @@ sub start_mysqlds()

       print "wanted mysqld binary.\n\n";

       $info_sent= 1;

-    $com.= $tmp;

     if (!$suffix_found)

@@ -376,6 +375,8 @@ sub start_mysqlds()

       $com.= $groups[$i];

+    $com.= $tmp;

     if ($opt_wsrep_new_cluster) {

       $com.= " --wsrep-new-cluster";

Both problems were introduced by commit commit 137d8ed3fee14335bd707474bd49f4e43b3bf309
for ~~MDEV-18863~~

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
154 kB
2019-10-05 10:47

Issue Links

causes

MDEV-21039 Server fails to start with mysqld_multi with mysqld_safe options

Closed

is caused by

MDEV-18863 Galera SST scripts can't read mysqld_multi's [mysqldN] option groups

Closed

relates to

MDEV-20728 /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1

Closed

MDEV-20868 mysqld_multi failed to run due to a basic script syntax error

Closed

links to

PR #1388

PR #1390

(1 links to)

Activity

Ascending order - Click to sort in descending order

Hartmut Holzgraefe created issue - 2019-09-18 08:34

Hartmut Holzgraefe made changes - 2019-09-18 08:37

Field	Original Value	New Value
Link		This issue is caused by ~~MDEV-18863~~ [ ~~MDEV-18863~~ ]

Hartmut Holzgraefe made changes - 2019-09-18 08:37

Description	Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of +elseif+ instead of perl +elsif+ The following one character change fixes this: {{noformat}} diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh index b8730e2624a..748925bef0b 100644 --- a/scripts/mysqld_multi.sh +++ b/scripts/mysqld_multi.sh @@ -349,7 +349,7 @@ sub start_mysqlds() $options[$j]= quote_shell_word($options[$j]); $tmp.= " $options[$j]"; } - elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24)) + elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24)) { $suffix_found= 1; } {{noformat}} But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required. The following should fix this for the default case, where +mysqld+ in the +[mysqld_multi]+ section is either given as +mysqld+ or +mysqld_multi+, as expected. It will fail though if +mysqld+ setting already contains a command line setting by itself ... {noformat} @@ -368,7 +368,6 @@ sub start_mysqlds() print "wanted mysqld binary.\n\n"; $info_sent= 1; } - $com.= $tmp; if (!$suffix_found) { @@ -376,6 +375,8 @@ sub start_mysqlds() $com.= $groups[$i]; } + $com.= $tmp; + if ($opt_wsrep_new_cluster) { $com.= " --wsrep-new-cluster"; } {noformat}	Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of +elseif+ instead of perl +elsif+ The following one character change fixes this: {{noformat}} diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh index b8730e2624a..748925bef0b 100644 --- a/scripts/mysqld_multi.sh +++ b/scripts/mysqld_multi.sh @@ -349,7 +349,7 @@ sub start_mysqlds() $options[$j]= quote_shell_word($options[$j]); $tmp.= " $options[$j]"; } - elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24)) + elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24)) { $suffix_found= 1; } {{noformat}} But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required. The following should fix this for the default case, where +mysqld+ in the +[mysqld_multi]+ section is either given as +mysqld+ or +mysqld_multi+, as expected. It will fail though if +mysqld+ setting already contains a command line setting by itself ... {noformat} @@ -368,7 +368,6 @@ sub start_mysqlds() print "wanted mysqld binary.\n\n"; $info_sent= 1; } - $com.= $tmp; if (!$suffix_found) { @@ -376,6 +375,8 @@ sub start_mysqlds() $com.= $groups[$i]; } + $com.= $tmp; + if ($opt_wsrep_new_cluster) { $com.= " --wsrep-new-cluster"; } {noformat} Both problems were introduced by commit commit 137d8ed3fee14335bd707474bd49f4e43b3bf309 for ~~MDEV-18863~~
Summary	Syntax error in mysqld_multi perl script	Syntax error, and option put in wrong place, in mysqld_multi perl script

Hartmut Holzgraefe made changes - 2019-09-18 08:41

Affects Version/s

10.4.8 [ 23721 ]

Hartmut Holzgraefe made changes - 2019-09-18 08:42

Description

Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of +elseif+ instead of perl +elsif+

The following one character change fixes this:

{{noformat}}
diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh
index b8730e2624a..748925bef0b 100644
--- a/scripts/mysqld_multi.sh
+++ b/scripts/mysqld_multi.sh
@@ -349,7 +349,7 @@ sub start_mysqlds()
         $options[$j]= quote_shell_word($options[$j]);
         $tmp.= " $options[$j]";
       }
- elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
+ elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
       {
         $suffix_found= 1;
       }
{{noformat}}

But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required.

The following should fix this for the default case, where +mysqld+ in the +[mysqld_multi]+ section is either given as +mysqld+ or +mysqld_multi+, as expected. It will fail though if +mysqld+ setting already contains a command line setting by itself ...

{noformat}
@@ -368,7 +368,6 @@ sub start_mysqlds()
       print "wanted mysqld binary.\n\n";
       $info_sent= 1;
     }
- $com.= $tmp;

     if (!$suffix_found)
     {
@@ -376,6 +375,8 @@ sub start_mysqlds()
       $com.= $groups[$i];
     }

+ $com.= $tmp;
+
     if ($opt_wsrep_new_cluster) {
       $com.= " --wsrep-new-cluster";
     }
{noformat}

Both problems were introduced by commit commit 137d8ed3fee14335bd707474bd49f4e43b3bf309
for ~~MDEV-18863~~

Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of +elseif+ instead of perl +elsif+

The following one character change fixes this:

{noformat}
diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh
index b8730e2624a..748925bef0b 100644
--- a/scripts/mysqld_multi.sh
+++ b/scripts/mysqld_multi.sh
@@ -349,7 +349,7 @@ sub start_mysqlds()
         $options[$j]= quote_shell_word($options[$j]);
         $tmp.= " $options[$j]";
       }
- elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
+ elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
       {
         $suffix_found= 1;
       }
{noformat}

But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required.

The following should fix this for the default case, where +mysqld+ in the +[mysqld_multi]+ section is either given as +mysqld+ or +mysqld_multi+, as expected. It will fail though if +mysqld+ setting already contains a command line setting by itself ...

{noformat}
@@ -368,7 +368,6 @@ sub start_mysqlds()
       print "wanted mysqld binary.\n\n";
       $info_sent= 1;
     }
- $com.= $tmp;

     if (!$suffix_found)
     {
@@ -376,6 +375,8 @@ sub start_mysqlds()
       $com.= $groups[$i];
     }

+ $com.= $tmp;
+
     if ($opt_wsrep_new_cluster) {
       $com.= " --wsrep-new-cluster";
     }
{noformat}

Both problems were introduced by commit commit 137d8ed3fee14335bd707474bd49f4e43b3bf309
for ~~MDEV-18863~~

Elena Stepanova made changes - 2019-09-18 13:09

Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Assignee		Julius Goryavsky [ sysprg ]

Geoff Montee (Inactive) made changes - 2019-09-18 16:43

Fix Version/s		10.1 [ 16100 ]
Fix Version/s		10.2 [ 14601 ]

Sergei Golubchik made changes - 2019-09-19 16:23

Priority

Critical [ 2 ]

Blocker [ 1 ]

Geoff Montee (Inactive) made changes - 2019-09-20 17:05

Affects Version/s

10.2.27 [ 23717 ]

Julius Goryavsky made changes - 2019-09-23 23:09

Status

Open [ 1 ]

In Progress [ 3 ]

Julius Goryavsky made changes - 2019-10-01 09:19

Fix Version/s		10.1.45 [ 23913 ]
Fix Version/s		10.2.29 [ 23911 ]
Fix Version/s		10.3.20 [ 23909 ]
Fix Version/s		10.4.10 [ 23907 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.1 [ 16100 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Geoff Montee (Inactive) made changes - 2019-10-04 21:47

Link

This issue relates to ~~MDEV-20728~~ [ ~~MDEV-20728~~ ]

Julius Goryavsky made changes - 2019-10-05 10:47

Attachment

screenshot-1.png [ 49086 ]

Anel Husakovic made changes - 2019-10-22 09:01

Link

This issue relates to ~~MDEV-20868~~ [ ~~MDEV-20868~~ ]

Anel Husakovic made changes - 2019-10-22 09:04

Remote Link

This issue links to "PR #1390 (Web Link)" [ 29302 ]

Anel Husakovic made changes - 2019-10-22 09:04

Remote Link

This issue links to "PR #1388 (Web Link)" [ 29303 ]

Julius Goryavsky made changes - 2019-10-29 13:14

Fix Version/s		10.1.42 [ 23407 ]
Fix Version/s		10.2.28 [ 23910 ]
Fix Version/s		10.3.19 [ 23908 ]
Fix Version/s		10.4.9 [ 23906 ]
Fix Version/s	10.4.10 [ 23907 ]
Fix Version/s	10.3.20 [ 23909 ]
Fix Version/s	10.2.29 [ 23911 ]
Fix Version/s	10.1.45 [ 23913 ]

Geoff Montee (Inactive) made changes - 2019-11-12 21:14

Link

This issue causes ~~MDEV-21039~~ [ ~~MDEV-21039~~ ]

Sergei Golubchik made changes - 2021-12-06 21:50

Workflow

MariaDB v3 [ 99731 ]

MariaDB v4 [ 156758 ]

Jira Automation (IT) made changes - 2024-07-04 03:32

Zendesk Related Tickets

185982 107273

People

Assignee:: Julius Goryavsky

Reporter:: Hartmut Holzgraefe

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 2019-09-18 08:34

Updated:: 2024-07-07 22:44

Resolved:: 2019-10-01 09:19

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration