[MDEV-20614] Syntax error, and option put in wrong place, in mysqld_multi perl script Created: 2019-09-18  Updated: 2020-08-25  Resolved: 2019-10-01

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Affects Version/s: 10.2.27, 10.3.18, 10.4.8
Fix Version/s: 10.2.28, 10.1.42, 10.3.19, 10.4.9

Type: Bug Priority: Blocker
Reporter: Hartmut Holzgraefe Assignee: Julius Goryavsky
Resolution: Fixed Votes: 0
Labels: None

Attachments: PNG File screenshot-1.png    
Issue Links:
Problem/Incident
causes MDEV-21039 Server fails to start with mysqld_mul... Closed
is caused by MDEV-18863 Galera SST scripts can't read mysqld_... Closed
Relates
relates to MDEV-20728 /usr/sbin/mysqld: unknown variable 'd... Closed
relates to MDEV-20868 mysqld_multi failed to run due to a b... Closed

 Description   

Current mysqld_multi perl script fails due to a syntax error introduced a syntax error due to use of elseif instead of perl elsif

The following one character change fixes this:

diff --git a/scripts/mysqld_multi.sh b/scripts/mysqld_multi.sh
 
index b8730e2624a..748925bef0b 100644
 
--- a/scripts/mysqld_multi.sh
 
+++ b/scripts/mysqld_multi.sh
 
@@ -349,7 +349,7 @@ sub start_mysqlds()
 
         $options[$j]= quote_shell_word($options[$j]);
 
         $tmp.= " $options[$j]";
 
       }
 
-      elseif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
 
+      elsif ("--defaults-group-suffix=" eq substr($options[$j], 0, 24))
 
       {
 
         $suffix_found= 1;
 
       }

But even with this fixed mysqld_multi can't start any server instance, as the new code in 10.3.18 does not pass --defaults-group-suffix as the very first option to mysqld, as required.

The following should fix this for the default case, where mysqld in the [mysqld_multi] section is either given as mysqld or mysqld_multi, as expected. It will fail though if mysqld setting already contains a command line setting by itself ...

@@ -368,7 +368,6 @@ sub start_mysqlds()
 
       print "wanted mysqld binary.\n\n";
 
       $info_sent= 1;
 
     }
 
-    $com.= $tmp;
 
 
     if (!$suffix_found)
 
     {
 
@@ -376,6 +375,8 @@ sub start_mysqlds()
 
       $com.= $groups[$i];
 
     }
 
 
+    $com.= $tmp;
 
+
 
     if ($opt_wsrep_new_cluster) {
 
       $com.= " --wsrep-new-cluster";
 
     }

Both problems were introduced by commit commit 137d8ed3fee14335bd707474bd49f4e43b3bf309
for MDEV-18863

 Comments   
Comment by Julius Goryavsky [ 2019-10-01 ]

Fixed, https://github.com/MariaDB/server/commit/2fba8f72a8ab560b87578830fafb51bd26c809ab

Comment by Geoff Montee (Inactive) [ 2019-10-01 ]

The "Fix Version/s" field for this bug report is set to the following: "10.1.45, 10.2.29, 10.3.20, 10.4.10".

Is that really correct? It looks wrong to me.

Shouldn't the "Fix Version/s" field be set to the next versions in each release series, which would mean the following?: "10.1.42, 10.2.28, 10.3.19, 10.4.9"

Also, it doesn't look like the fix has been pushed to the main 10.1 branch yet.

Comment by Julius Goryavsky [ 2019-10-04 ]

Fix is already pushed to the main branch for 10.1 (commit 144217339d8dc2d6e00542cd25d97e39b90afa3f, in the main branch since Sep 25 2019, 14:00:39) and it is pushed to the main branch for 10.2 (commit bc70862e13f32756695d5781c793f2525aeb7187) and then merged with 10.3 and 10.4 (there same commit id). Perhaps I indicated the wrong version numbers on JIRA because I just selected the latter in the list.

Comment by Geoff Montee (Inactive) [ 2019-10-04 ]

Hi sysprg,

Fix is already pushed to the main branch for 10.1 (commit 144217339d8dc2d6e00542cd25d97e39b90afa3f, in the main branch since Sep 25 2019, 14:00:39)

Hmm, weird. GitHub shows that commit 144217339d8dc2d6e00542cd25d97e39b90afa3f has only been pushed to the 10.5 branch:

https://github.com/MariaDB/server/commit/144217339d8dc2d6e00542cd25d97e39b90afa3f

and it is pushed to the main branch for 10.2 (commit bc70862e13f32756695d5781c793f2525aeb7187) and then merged with 10.3 and 10.4 (there same commit id).

GitHub shows that commit bc70862e13f32756695d5781c793f2525aeb7187 has also only been pushed to the 10.5 branch:

https://github.com/MariaDB/server/commit/bc70862e13f32756695d5781c793f2525aeb7187

I'm not sure if GitHub is wrong, or if something went wrong with your pushes.

Perhaps I indicated the wrong version numbers on JIRA because I just selected the latter in the list.

I don't believe that selecting the last in the list is the proper method. I believe that the proper method is to pick the first releases in the "Unreleased Versions" list.

Comment by Julius Goryavsky [ 2019-10-05 ]

Hi, GeoffMontee,

Perhaps github does not display all the branches - for verification, you can simply select branch 10.1 and see the list of commits for it (screeenshot attached) or switch to 10.1 and see git log for it on the command line:

................
 
................
 
 
 
commit 144217339d8dc2d6e00542cd25d97e39b90afa3f
 
Author: Julius Goryavsky <julius.goryavsky@mariadb.com>
 
Date:   Wed Sep 25 14:00:39 2019 +0200
 
 
 
    MDEV-20614: Syntax error, and option put in wrong place
 
    
    A syntax error in the mysqld_multi.sh script has been fixed
 
    here + a "--defaults-group-suffix" option has been moved to
 
    the top of the mysqld options list.
 
................

Comment by Anel Husakovic [ 2019-10-22 ]

Hi sysprg,
I don't see commits from PR #1388 and PR #1390 from contributor?
Here is a history 10.5/

Generated at Thu Feb 08 09:00:50 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.