Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19035

Make MariaDB Connector/C handle my.cnf parsing for clients

Details

    Description

      Client tools like "mysql" use MariaDB Connector/C in 10.2 and above after MDEV-9293. However, the client tools still use the server code to parse my.cnf and other option/configuration files. See here:

      https://github.com/MariaDB/server/blob/c0ba036b774b8e35567dccce421890d2199f30ce/client/mysql.cc#L1176

      https://github.com/MariaDB/server/blob/c0ba036b774b8e35567dccce421890d2199f30ce/include/my_default.h#L50

      https://github.com/MariaDB/server/blob/c0ba036b774b8e35567dccce421890d2199f30ce/mysys/my_default.c#L464

      Do we want to make MariaDB Connector/C handle this job for clients at some point too?

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. CONC-394 Some TLS-related options are not settable in my.cnf

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-395 Dashes and underscores are not interchangeable in options in my.cnf

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-396 !includedir in my.cnf does not include all .cnf and .ini files in the directory

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. CONC-399 Add option that corresponds to --defaults-extra-file MariaDB command-line option

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Task - A task that needs to be done. CONC-404 Add option that corresponds to --defaults-group-suffix MariaDB command-line option

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. CONC-415 Option prefixes not supported in my.cnf

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CONC-416 On Windows, C/C looks for first my.cnf/my.ini in GetSystemDirectory() instead of GetSystemWindowsDirectory()

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-9055 replace libmysqlclient with Connector/C

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. MDEV-9293 change clients to use Connector/C

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            wlad Vladislav Vaintroub added a comment -

            in my opinion, C/C has no business in my.cnf and my.ini
            C/C is collection of APIs, designed for database access. There is mysql_option() to control the behavior, and this should be enough for an API.

            Do we want C/C to handle command line, and INI parsing for the server? Probably not

            wlad Vladislav Vaintroub added a comment - in my opinion, C/C has no business in my.cnf and my.ini C/C is collection of APIs, designed for database access. There is mysql_option() to control the behavior, and this should be enough for an API. Do we want C/C to handle command line, and INI parsing for the server? Probably not
            greenman Ian Gilfillan added a comment -

            Can this be closed as wontfix?

            greenman Ian Gilfillan added a comment - Can this be closed as wontfix?

            People

              Unassigned Unassigned
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.