Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-395

Dashes and underscores are not interchangeable in options in my.cnf

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.0.8
    • 3.1.1
    • None
    • None

    Description

      When the server parses my.cnf or other option/configuration files, dashes and underscores are interchangeable in options:

      Dashes (-) and underscores (_) in options are interchangeable.

      https://mariadb.com/kb/en/library/configuring-mariadb-with-option-files/#option-file-syntax

      This is not the case with MariaDB Connector/C:

      Unlike with the server, dashes (-) and underscores (_) in options are not interchangeable for MariaDB Connector/C. Options must be specified exactly as they are defined.

      https://mariadb.com/kb/en/library/configuring-mariadb-connectorc-with-option-files/#option-file-syntax

      I think it would be pretty easy to fix this.

      One potential fix would be to modify the _mariadb_set_conf_option function, so that it makes a copy of the config_option C-string argument and replaces all underscores (_) with dashes (-) before doing the strcmp:

      https://github.com/MariaDB/mariadb-connector-c/blob/1285dc72a043f09d9a51abcfc3a4fbfb5192067e/libmariadb/mariadb_lib.c#L696

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-19035 Make MariaDB Connector/C handle my.cnf parsing for clients

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CONC-327 !include/!includedir not parsed in my.cnf

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. CONC-396 !includedir in my.cnf does not include all .cnf and .ini files in the directory

          • Major - Major loss of function.
          • Open

          Task - A task that needs to be done. CONC-402 Replace underscores with dashes in conf_key values in mariadb_defaults array

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CONC-404 Add option that corresponds to --defaults-group-suffix MariaDB command-line option

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CONC-394 Some TLS-related options are not settable in my.cnf

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. CONC-399 Add option that corresponds to --defaults-extra-file MariaDB command-line option

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Task - A task that needs to be done. CONC-415 Option prefixes not supported in my.cnf

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. CONC-416 On Windows, C/C looks for first my.cnf/my.ini in GetSystemDirectory() instead of GetSystemWindowsDirectory()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. ODBC-229 Add parameters that correspond to MYSQL_READ_DEFAULT_FILE and MYSQL_READ_DEFAULT_GROUP options from MariaDB Connector/C

          • Major - Major loss of function.
          • Closed

          Activity

            serg Sergei Golubchik added a comment -

            I agree, it should behave as in the server

            serg Sergei Golubchik added a comment - I agree, it should behave as in the server

            People

              georg Georg Richter
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.