Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16678

Use MDL for innodb background threads instead of dict_operation_lock

Details

    Description

      Purge thread does take shared lock on innodb dictionary lock while processing the undo log record to avoid the dropping of table. But it also blocks DDL for
      the InnoDB. There are few issues exist for virtual column computation.
      Because purge thread acquires mdl lock for virtual column computation and could
      have deadlock with DDL. (fixed in 10.2+)

      Allow InnoDB background thread to take MDL lock on the table. In that case, it blocks DDL only for that table.

      For FOREIGN KEY constraint checks, we would prefer not to acquire dict_operation_lock S-latch, and rely on the correct acquisition of MDL on the SQL layer (to be covered by MDEV-21175).

      Attachments

        1. MDEV-16678_1.tgz
          17 kB
          Matthias Leich
        2. MDEV-16678_2.test
          5 kB
          Matthias Leich
        3. MDEV-16678.ods
          71 kB
          Axel Schwenke

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21282 Assertion 'mariadb_table' failed in gcol.innodb_virtual_debug_purge

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-21327 Notify tpool threadpool about MDL waits

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21546 main.backup_stages occasionally fails with lock wait timeout

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22060 MSAN use-of-uninitialized-value in main.query_cache_innodb

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22751 Uninitialized tbl_len in dict_acquire_mdl_shared() in purge after DDL

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22824 Buffer overflow in dict_table_t::parse_name()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23422 innodb_zip.restart fails in buildbot with wrong result

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35567 Unexpected table metadata locks held by background operations can cause phantom ER_LOCK_WAIT_TIMEOUT and possibly other errors

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-36122 Assertion failure ctx0->old_table->get_ref_count() == 1 in ha_innobase::commit_inplace_alter_table()

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21175 Remove dict_table_t::n_foreign_key_checks_running from InnoDB

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21281 main.backup_interaction fails intermittently

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21400 encryption.innochecksum fails during shutdown

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-23026 Server hangs on purge or failing assertions `!rw_lock_own_flagged(lock, RW_LOCK_FLAG_X | RW_LOCK_FLAG_S)' / `!rw_lock_own(lock, RW_LOCK_S)'

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24661 The test innodb.innodb_wl6326_big often times out

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18654 Failing assertion: sym_node->table != NULL in buildbot with innodb_fts.sync_ddl and outside

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20874 Wrong handling of 'table was dropped' error in purge thread

          • Major - Major loss of function.
          • In Progress

          Task - A task that needs to be done. MDEV-20876 Remove node->vcol_op_failed() method

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21283 InnoDB: MySQL is trying to drop database…open handles to table …`#sql-ib1148`

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21344 Valgrind uninitialised value warnings in dict_acquire_mdl_shared / dict_table_open_on_id

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22867 Assertion `instant.n_core_fields == n_core_fields' failed in dict_index_t::instant_add_field

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22958 innodb.instant_alter_debug fails in buildbot with wrong result

          • Major - Major loss of function.
          • Closed

          Activity

            Transition Time In Source Status Execution Times
            Thirunarayanan Balathandayuthapani made transition -
            Open In Progress
            		426d 19h 41m 1
            Marko Mäkelä made transition -
            In Progress Stalled
            		93d 5h 32m 1
            Marko Mäkelä made transition -
            Stalled Closed
            		5d 4h 46m 1

            People

              marko Marko Mäkelä
              thiru Thirunarayanan Balathandayuthapani
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.