Details

    Description

      Aria can under some circumstances hang in log_handler.cc::translog_buffer_flush

      The hang is caused because of buffer->copy_to_buffer_in_progress getting out of sync.

      I have attached a minimal stacktrace from 10.2 that shows one hang.

      Attachments

        Activity

          monty Michael Widenius created issue -
          sanja Oleksandr Byelkin made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          sanja Oleksandr Byelkin made changes -
          Fix Version/s 5.5 [ 15800 ]
          sanja Oleksandr Byelkin made changes -
          Affects Version/s 10.2 [ 14601 ]
          Affects Version/s 10.3 [ 22126 ]
          Affects Version/s 10.0 [ 16000 ]
          Affects Version/s 10.1 [ 16100 ]
          sanja Oleksandr Byelkin made changes -
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]

          Might be related to MDEV-4312 (see the last stack trace in the comment, there is also a hang in translog_buffer_flush).

          elenst Elena Stepanova added a comment - Might be related to MDEV-4312 (see the last stack trace in the comment, there is also a hang in translog_buffer_flush).
          sanja Oleksandr Byelkin made changes -
          Sprint 10.2.13 [ 228 ]
          sanja Oleksandr Byelkin made changes -
          Status In Progress [ 3 ] Stalled [ 10000 ]
          sanja Oleksandr Byelkin made changes -
          Status Stalled [ 10000 ] In Progress [ 3 ]
          sanja Oleksandr Byelkin made changes -
          Status In Progress [ 3 ] Stalled [ 10000 ]
          sanja Oleksandr Byelkin made changes -
          Assignee Oleksandr Byelkin [ sanja ] Elena Stepanova [ elenst ]
          sanja Oleksandr Byelkin added a comment - - edited

          Passed for testing under load.
          bb-5.5-MDEV-15113

          sanja Oleksandr Byelkin added a comment - - edited Passed for testing under load. bb-5.5- MDEV-15113

          bb-5.5-MDEV-15113 5676edf451cc9f653c2 doesn't build.

          Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecache.c.o
          /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c: In function ‘used_buffs_urgent_unlock’:
          /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
             for (uint i= buffs->unlck_ptr; i < buffs->wrt_ptr; i++)
             ^
          /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
          [ 81%] Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecaches.c.o
          storage/maria/CMakeFiles/aria.dir/build.make:1411: recipe for target 'storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o' failed
          make[2]: *** [storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o] Error 1
          make[2]: *** Waiting for unfinished jobs....
          CMakeFiles/Makefile2:3570: recipe for target 'storage/maria/CMakeFiles/aria.dir/all' failed
          make[1]: *** [storage/maria/CMakeFiles/aria.dir/all] Error 2
          

          elenst Elena Stepanova added a comment - bb-5.5- MDEV-15113 5676edf451cc9f653c2 doesn't build. Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecache.c.o /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c: In function ‘used_buffs_urgent_unlock’: /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode for (uint i= buffs->unlck_ptr; i < buffs->wrt_ptr; i++) ^ /data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code [ 81%] Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecaches.c.o storage/maria/CMakeFiles/aria.dir/build.make:1411: recipe for target 'storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o' failed make[2]: *** [storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o] Error 1 make[2]: *** Waiting for unfinished jobs.... CMakeFiles/Makefile2:3570: recipe for target 'storage/maria/CMakeFiles/aria.dir/all' failed make[1]: *** [storage/maria/CMakeFiles/aria.dir/all] Error 2
          elenst Elena Stepanova made changes -
          Assignee Elena Stepanova [ elenst ] Oleksandr Byelkin [ sanja ]
          sanja Oleksandr Byelkin made changes -
          Assignee Oleksandr Byelkin [ sanja ] Elena Stepanova [ elenst ]

          I didn't get anything relevant to the change while running tests on bb-5.5-MDEV-15113 7435cebf49f, please go ahead in push

          MDEV-4312 has to stay open, at least the crash is still reproducible.

          elenst Elena Stepanova added a comment - I didn't get anything relevant to the change while running tests on bb-5.5- MDEV-15113 7435cebf49f, please go ahead in push MDEV-4312 has to stay open, at least the crash is still reproducible.
          elenst Elena Stepanova made changes -
          Assignee Elena Stepanova [ elenst ] Oleksandr Byelkin [ sanja ]
          elenst Elena Stepanova made changes -
          Assignee Oleksandr Byelkin [ sanja ] Elena Stepanova [ elenst ]

          On the 2nd thought, I'm not quite happy with my test coverage yet, I need to run more tests.

          elenst Elena Stepanova added a comment - On the 2nd thought, I'm not quite happy with my test coverage yet, I need to run more tests.
          sanja Oleksandr Byelkin made changes -
          Sprint 10.2.13 [ 228 ] 10.2.13, 10.3.5-1 [ 228, 229 ]
          elenst Elena Stepanova made changes -
          Assignee Elena Stepanova [ elenst ] Oleksandr Byelkin [ sanja ]
          serg Sergei Golubchik made changes -
          Sprint 10.2.13, 10.3.5-1 [ 228, 229 ]
          sanja Oleksandr Byelkin made changes -
          Fix Version/s 5.5.61 [ 22914 ]
          Fix Version/s 10.0.36 [ 22916 ]
          Fix Version/s 10.1.34 [ 23100 ]
          Fix Version/s 10.2.16 [ 23110 ]
          Fix Version/s 10.3.8 [ 23113 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 5.5 [ 15800 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.3 [ 22126 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 85195 ] MariaDB v4 [ 153678 ]

          People

            sanja Oleksandr Byelkin
            monty Michael Widenius
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.