[MDEV-15113] Hang in Aria loghandler Created: 2018-01-29  Updated: 2018-06-12  Resolved: 2018-06-12

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - Aria
Affects Version/s: 5.5, 10.0, 10.1, 10.2, 10.3
Fix Version/s: 5.5.61, 10.0.36, 10.1.34, 10.2.16, 10.3.8

Type: Bug Priority: Major
Reporter: Michael Widenius Assignee: Oleksandr Byelkin
Resolution: Fixed Votes: 0
Labels: None

Attachments: Text File aria_test_hangs_on_insert.txt    

 Description   

Aria can under some circumstances hang in log_handler.cc::translog_buffer_flush

The hang is caused because of buffer->copy_to_buffer_in_progress getting out of sync.

I have attached a minimal stacktrace from 10.2 that shows one hang.

 Comments   
Comment by Elena Stepanova [ 2018-01-29 ]

Might be related to MDEV-4312 (see the last stack trace in the comment, there is also a hang in translog_buffer_flush).

Comment by Oleksandr Byelkin [ 2018-02-01 ]

Passed for testing under load.
bb-5.5-MDEV-15113

Comment by Elena Stepanova [ 2018-02-01 ]

bb-5.5-MDEV-15113 5676edf451cc9f653c2 doesn't build.

Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecache.c.o
 
/data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c: In function ‘used_buffs_urgent_unlock’:
 
/data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: error: ‘for’ loop initial declarations are only allowed in C99 or C11 mode
 
   for (uint i= buffs->unlck_ptr; i < buffs->wrt_ptr; i++)
 
   ^
 
/data/src/bb-5.5-MDEV-15113/storage/maria/ma_loghandler.c:4976:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
 
[ 81%] Building C object storage/maria/CMakeFiles/aria.dir/ma_pagecaches.c.o
 
storage/maria/CMakeFiles/aria.dir/build.make:1411: recipe for target 'storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o' failed
 
make[2]: *** [storage/maria/CMakeFiles/aria.dir/ma_loghandler.c.o] Error 1
 
make[2]: *** Waiting for unfinished jobs....
 
CMakeFiles/Makefile2:3570: recipe for target 'storage/maria/CMakeFiles/aria.dir/all' failed
 
make[1]: *** [storage/maria/CMakeFiles/aria.dir/all] Error 2

Comment by Elena Stepanova [ 2018-02-04 ]

I didn't get anything relevant to the change while running tests on bb-5.5-MDEV-15113 7435cebf49f, please go ahead in push

MDEV-4312 has to stay open, at least the crash is still reproducible.

Comment by Elena Stepanova [ 2018-02-06 ]

On the 2nd thought, I'm not quite happy with my test coverage yet, I need to run more tests.

Generated at Thu Feb 08 08:18:46 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.