Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14630

Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to CONST_ITEM

Details

    Description

      The enumeration Item::Type has data-type specific constants for literals:

      • STRING_ITEM
      • INT_ITEM
      • REAL_ITEM
      • DECIMAL_ITEM
      • DATE_ITEM

      This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

      We'll do the following:

      • Remove the data type specific enumeration values from Item::Type
      • Add a new value CONST_ITEM
      • Fix the calling code to test for CONST_ITEM, and when it is necessary, detect the data type using other means, such as type_handler(), or by adding new virtual methods into Item or its descendants.

      Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() (when assigned to an integer value), reports itself as INT_ITEM. This makes parameter work as a position rather than an expression when used in ORDER BY:

        if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
      		 
            !from_window_spec)

      This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15654 ADDTIME creates invalid timestamp value near DST changes

          • Major - Major loss of function.
          • Closed
          is blocked by

          Task - A task that needs to be done. MDEV-15597 Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-15689 Fix Item_func_set_collation to pass the collation using CHARSET_INFO instead of Item

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-15702 Remove the use of STRING_ITEM from Item_func_date_format::fix_length_and_dec()

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15714 Remove the use of STRING_ITEM from the parser

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16309 Split ::create_tmp_field() into virtual methods in Item

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16316 Replace INT_ITEM references in the code behind ORDER, LIMIT, PROCEDURE clause

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16320 Replace INT_ITEM references in sql_select.cc

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16379 Move Item_basic_const::used_table_map to Item_cache

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16388 Replace member Item::fixed to virtual method is_fixed()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16408 Remove tests for Item::type() in Item_basic_value::eq()

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Summary Replace {STRING|INT|REAL|DECIMAL|DATE_ITEM} to LITERAL_ITEM Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to LITERAL_ITEM
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins.

            We'll do the following:
            - Remove the data type specific enumeration values
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins.

            We'll do the following:
            - Remove the data type specific enumeration values
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins.

            We'll do the following:
            - Remove the data type specific enumeration values
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() assigned to an integer value, reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() assigned to an integer value, reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}, or by adding new virtual methods into Item or its descendants.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() assigned to an integer value, reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}, or by adding new virtual methods into Item or its descendants.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() assigned to an integer value, reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}, or by adding new virtual methods into Item or its descendants.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() (when assigned to an integer value), reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.3 [ 22126 ]
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Summary Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to LITERAL_ITEM Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to CONST_ITEM
            bar Alexander Barkov made changes -
            Description The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{LITERAL_ITEM}}
            - Fix the calling code to test for {{LITERAL_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}, or by adding new virtual methods into Item or its descendants.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() (when assigned to an integer value), reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            		The enumeration {{Item::Type}} has data-type specific constants for literals:

            - STRING_ITEM
            - INT_ITEM
            - REAL_ITEM
            - DECIMAL_ITEM
            - DATE_ITEM

            This is not friendly to upcoming data type plugins, as they'll need to create their own literals.

            We'll do the following:
            - Remove the data type specific enumeration values from {{Item::Type}}
            - Add a new value {{CONST_ITEM}}
            - Fix the calling code to test for {{CONST_ITEM}}, and when it is necessary, detect the data type using other means, such as {{type_handler()}}, or by adding new virtual methods into Item or its descendants.

            Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() (when assigned to an integer value), reports itself as {{INT_ITEM}}. This makes parameter work as a position rather than an expression when used in {{ORDER BY}}:
            {code:cpp}
              if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
                  !from_window_spec)
            {code}
            This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-06-06 10:09:26.0 2018-06-06 10:09:26.602
            bar Alexander Barkov made changes -
            Fix Version/s 10.4.0 [ 23115 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            julien.fritsch Julien Fritsch made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 84390 ] MariaDB v4 [ 133418 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.