Type:
Task
Priority:
Major
Resolution:
Fixed
The enumeration Item::Type has data-type specific constants for literals:
STRING_ITEM
INT_ITEM
REAL_ITEM
DECIMAL_ITEM
DATE_ITEM
This is not friendly to upcoming data type plugins, as they'll need to create their own literals.
We'll do the following:
Remove the data type specific enumeration values from Item::Type
Add a new value CONST_ITEM
Fix the calling code to test for CONST_ITEM , and when it is necessary, detect the data type using other means, such as type_handler() , or by adding new virtual methods into Item or its descendants.
Note, under terms of this task, we'll preserve the old behavior. For example, Item_param::type() (when assigned to an integer value), reports itself as INT_ITEM . This makes parameter work as a position rather than an expression when used in ORDER BY :
if (order_item->type() == Item::INT_ITEM && order_item->basic_const_item() &&
!from_window_spec)
This behavior was most likely introduced as a side effect. The new implementation will preserve the old behavior, including side effects like this.
There are no comments yet on this issue.
{"report":{"fcp":1757.7000000476837,"ttfb":496.30000019073486,"pageVisibility":"visible","entityId":64788,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"99185ec4-2eab-4d14-8ac9-b770b580987a","navigationType":0,"readyForUser":1862.2000000476837,"redirectCount":0,"resourceLoadedEnd":1629,"resourceLoadedStart":501.60000014305115,"resourceTiming":[{"duration":401.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":501.60000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":501.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":903.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":401.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":501.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":501.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":903.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":411,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":502.10000014305115,"connectEnd":502.10000014305115,"connectStart":502.10000014305115,"domainLookupEnd":502.10000014305115,"domainLookupStart":502.10000014305115,"fetchStart":502.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":502.10000014305115,"responseEnd":913.1000001430511,"responseStart":913.1000001430511,"secureConnectionStart":502.10000014305115},{"duration":477.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":502.30000019073486,"connectEnd":502.30000019073486,"connectStart":502.30000019073486,"domainLookupEnd":502.30000019073486,"domainLookupStart":502.30000019073486,"fetchStart":502.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":502.30000019073486,"responseEnd":979.7000000476837,"responseStart":979.7000000476837,"secureConnectionStart":502.30000019073486},{"duration":481.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":502.40000009536743,"connectEnd":502.40000009536743,"connectStart":502.40000009536743,"domainLookupEnd":502.40000009536743,"domainLookupStart":502.40000009536743,"fetchStart":502.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":502.40000009536743,"responseEnd":983.5,"responseStart":983.5,"secureConnectionStart":502.40000009536743},{"duration":481.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":502.60000014305115,"connectEnd":502.60000014305115,"connectStart":502.60000014305115,"domainLookupEnd":502.60000014305115,"domainLookupStart":502.60000014305115,"fetchStart":502.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":502.60000014305115,"responseEnd":984,"responseStart":984,"secureConnectionStart":502.60000014305115},{"duration":481.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":502.80000019073486,"connectEnd":502.80000019073486,"connectStart":502.80000019073486,"domainLookupEnd":502.80000019073486,"domainLookupStart":502.80000019073486,"fetchStart":502.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":502.80000019073486,"responseEnd":984.3000001907349,"responseStart":984.3000001907349,"secureConnectionStart":502.80000019073486},{"duration":562.9000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":502.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":502.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1065.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":481.89999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":503.10000014305115,"connectEnd":503.10000014305115,"connectStart":503.10000014305115,"domainLookupEnd":503.10000014305115,"domainLookupStart":503.10000014305115,"fetchStart":503.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":503.10000014305115,"responseEnd":985,"responseStart":985,"secureConnectionStart":503.10000014305115},{"duration":562.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":503.2000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":503.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1065.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":482.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":503.40000009536743,"connectEnd":503.40000009536743,"connectStart":503.40000009536743,"domainLookupEnd":503.40000009536743,"domainLookupStart":503.40000009536743,"fetchStart":503.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":503.40000009536743,"responseEnd":985.6000001430511,"responseStart":985.6000001430511,"secureConnectionStart":503.40000009536743},{"duration":684.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":514.7000000476837,"connectEnd":514.7000000476837,"connectStart":514.7000000476837,"domainLookupEnd":514.7000000476837,"domainLookupStart":514.7000000476837,"fetchStart":514.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":514.7000000476837,"responseEnd":1199.5,"responseStart":1199.5,"secureConnectionStart":514.7000000476837},{"duration":754.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":514.9000000953674,"connectEnd":514.9000000953674,"connectStart":514.9000000953674,"domainLookupEnd":514.9000000953674,"domainLookupStart":514.9000000953674,"fetchStart":514.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":514.9000000953674,"responseEnd":1269.8000001907349,"responseStart":1269.8000001907349,"secureConnectionStart":514.9000000953674},{"duration":118.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1081.7000000476837,"connectEnd":1081.7000000476837,"connectStart":1081.7000000476837,"domainLookupEnd":1081.7000000476837,"domainLookupStart":1081.7000000476837,"fetchStart":1081.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":1081.7000000476837,"responseEnd":1199.9000000953674,"responseStart":1199.9000000953674,"secureConnectionStart":1081.7000000476837},{"duration":423,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1206,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1206,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1629,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":327,"responseStart":497,"responseEnd":515,"domLoading":500,"domInteractive":1951,"domContentLoadedEventStart":1957,"domContentLoadedEventEnd":2024,"domComplete":2777,"loadEventStart":2777,"loadEventEnd":2778,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1916.1000001430511},{"name":"bigPipe.sidebar-id.end","time":1916.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.start","time":1917.1000001430511},{"name":"bigPipe.activity-panel-pipe-id.end","time":1917.7000000476837},{"name":"activityTabFullyLoaded","time":2032}],"measures":[],"correlationId":"3cd4bb83341d3d","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":109,"dbReadsTimeInMs":20,"dbConnsTimeInMs":29,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}