Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14265

RPMLint warning: shared-lib-calls-exit

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1.20
    • 10.1.32
    • Embedded Server
    • None
    • Fedora rawhide
    • 10.1.30, 10.1.32

    Description

      mariadb-embedded.x86_64: W:
      shared-lib-calls-exit /usr/lib64/libmysqld.so.19 exit@GLIBC_2.2.5

      Should be similar to CONC-290 ?

      Attachments

        Issue Links

          Activity

            Part of MDEV-8378.

            svoj Sergey Vojtovich added a comment - Part of MDEV-8378 .

            serg, please review fix for this bug. It fixes 5 of 6 exit's that I could find.

            I'd appreciate if you could suggest how we should fix last one: exit(0) from my_load_defaults with --print-defaults.

            svoj Sergey Vojtovich added a comment - serg , please review fix for this bug. It fixes 5 of 6 exit's that I could find. I'd appreciate if you could suggest how we should fix last one: exit(0) from my_load_defaults with --print-defaults.

            5 of 6 exit() calls will be fixed in 10.1.30 by this patch: https://github.com/MariaDB/server/commit/2cd316911309e3db4007aa224f7874bfbeb14032

            Last exit() call should be fixed during the next sprint.

            svoj Sergey Vojtovich added a comment - 5 of 6 exit() calls will be fixed in 10.1.30 by this patch: https://github.com/MariaDB/server/commit/2cd316911309e3db4007aa224f7874bfbeb14032 Last exit() call should be fixed during the next sprint.
            danblack Daniel Black added a comment -

            my_load_defaults with --print-defaults - DBUG_RETURN(2). At least the API for the calling program is the same and the calling program should handle this as a fatal error and assumedly do its own exit (or continue based on embedded mariadb being unavailable). The alternative is silently ignoring it in the --print-defaults which perhaps introduces unexpected behaviour.

            danblack Daniel Black added a comment - my_load_defaults with --print-defaults - DBUG_RETURN(2) . At least the API for the calling program is the same and the calling program should handle this as a fatal error and assumedly do its own exit (or continue based on embedded mariadb being unavailable). The alternative is silently ignoring it in the --print-defaults which perhaps introduces unexpected behaviour.
            svoj Sergey Vojtovich added a comment - serg , please review fix for this bug at https://github.com/MariaDB/server/commit/7a3d9b6439d0639c9ed736b3e75e48abbc9b3c80

            ok to push

            serg Sergei Golubchik added a comment - ok to push

            People

              svoj Sergey Vojtovich
              mschorm Michal Schorm
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.