[MDEV-14265] RPMLint warning: shared-lib-calls-exit Created: 2017-11-02 Updated: 2018-03-16 Resolved: 2018-03-16 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Embedded Server |
| Affects Version/s: | 10.1.20 |
| Fix Version/s: | 10.1.32 |
| Type: | Bug | Priority: | Major |
| Reporter: | Michal Schorm | Assignee: | Sergey Vojtovich |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Fedora rawhide |
||
| Issue Links: |
|
||||||||
| Sprint: | 10.1.30, 10.1.32 | ||||||||
| Description |
|
mariadb-embedded.x86_64: W: – Should be similar to CONC-290 ? |
| Comments |
| Comment by Sergey Vojtovich [ 2017-12-12 ] |
|
Part of |
| Comment by Sergey Vojtovich [ 2017-12-18 ] |
|
serg, please review fix for this bug. It fixes 5 of 6 exit's that I could find. I'd appreciate if you could suggest how we should fix last one: exit(0) from my_load_defaults with --print-defaults. |
| Comment by Sergey Vojtovich [ 2017-12-19 ] |
|
5 of 6 exit() calls will be fixed in 10.1.30 by this patch: https://github.com/MariaDB/server/commit/2cd316911309e3db4007aa224f7874bfbeb14032 Last exit() call should be fixed during the next sprint. |
| Comment by Daniel Black [ 2018-02-10 ] |
|
my_load_defaults with --print-defaults - DBUG_RETURN(2). At least the API for the calling program is the same and the calling program should handle this as a fatal error and assumedly do its own exit (or continue based on embedded mariadb being unavailable). The alternative is silently ignoring it in the --print-defaults which perhaps introduces unexpected behaviour. |
| Comment by Sergey Vojtovich [ 2018-03-15 ] |
|
serg, please review fix for this bug at https://github.com/MariaDB/server/commit/7a3d9b6439d0639c9ed736b3e75e48abbc9b3c80 |
| Comment by Sergei Golubchik [ 2018-03-15 ] |
|
ok to push |