Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8378

Debian: the Lintian complains about many "shlib-calls-exit" in many of the plugins

Details

    • 10.0.23, 10.0.25

    Description

      See http://labs.seravo.fi/~otto/mariadb-repo/mariadb-10.0-sid-amd64/lintian-0f7cb30.log and https://lintian.debian.org/tags/shlib-calls-exit.html.

      The following shared libraries call exit:

      • libdaemon_example.so - there seem to be no reason for exit(), use DBUG_RETURN(1) instead. (fixed)
      • libmysqld.so.18 - to be analyzed
      • ha_oqgraph.so - there's no exit() in oqgraph sources, most probably called by boost (grep headers for exit()) (fixed)
      • ha_connect.so - either replace with abort() or keep exit(), or reassign to Oliver to handle this properly. (fixed)
      • ha_innodb.so - lots of exits, either replace with abort() or keep exit(), or reassign to Jan to handle this properly.
      • ha_mroonga.so - lots of exits, either replace with abort() or keep exit(), or reassign to Kentoku to handle this properly.
      • ha_spider.so - either replace with abort() or keep exit(), or reassign to Kentoku to handle this properly. (fixed)
      • handlersocket.so - report upstream? (fixed)

      Lintian suggests:

      In the case of an error, the library should instead return an appropriate error code to the calling program which can then determine how to handle the error, including performing any required clean-up.

      Note: to find out if shared library has exit calls use something like nm|grep exit

      Attachments

        Issue Links

          Activity

            Transition Time In Source Status Execution Times
            Sergey Vojtovich made transition -
            Open In Review
            171d 23h 6m 1
            Sergei Golubchik made transition -
            In Review Stalled
            1d 10h 18m 1
            Sergey Vojtovich made transition -
            Stalled Closed
            825d 9h 23m 1

            People

              svoj Sergey Vojtovich
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.