While building RocksDB I get a fatal compilation error
/usr/bin/c++ -DHAVE_CONFIG_H -DLZ4 -DMYSQL_DYNAMIC_PLUGIN -DOS_FREEBSD -DROCKSDB_JEMALLOC -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_PLATFORM_POSIX -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -DZLIB -DZSTD -Drocksdb_EXPORTS -Iinclude -Isql -Ipcre -Istorage/rocksdb/rocksdb -Istorage/rocksdb/rocksdb/include -isystem storage/rocksdb/rocksdb/third-party/gtest-1.7.0/fused-src -Istorage/rocksdb/rocksdb/util -I/usr/include -I/usr/local/include -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -DDBUG_OFF -fPIC -std=c++11 -MD -MT storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -MF storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o.d -o storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -c storage/rocksdb/rdb_datadic.cc
|
In file included from storage/rocksdb/rdb_datadic.cc:26:
|
In file included from storage/rocksdb/./rdb_datadic.h:35:
|
storage/rocksdb/./ha_rocksdb.h:1066:3: warning: declaration does not declare anything [-Wmissing-declarations]
|
MY_ATTRIBUTE((__nonnull__, __warn_unused_result__));
|
^
|
storage/rocksdb/rdb_mariadb_port.h:18:27: note: expanded from macro 'MY_ATTRIBUTE'
|
# define MY_ATTRIBUTE(A) __attribute__(A)
|
^
|
In file included from storage/rocksdb/rdb_datadic.cc:26:
|
In file included from storage/rocksdb/./rdb_datadic.h:36:
|
storage/rocksdb/./properties_collector.h:84:27: warning: 'AddUserKey' overrides a member function but is not marked 'override'
|
[-Winconsistent-missing-override]
|
virtual rocksdb::Status AddUserKey(const rocksdb::Slice &key,
|
^
|
storage/rocksdb/rocksdb/include/rocksdb/table_properties.h:89:18: note: overridden virtual function is here
|
virtual Status AddUserKey(const Slice& key, const Slice& value,
|
^
|
storage/rocksdb/rdb_datadic.cc:371:19: error: no member named 'strtoul' in namespace 'std'; did you mean simply 'strtoul'?
|
*ttl_duration = std::strtoull(ttl_duration_str.c_str(), nullptr, 0);
|
^~~~~
|
/usr/include/stdlib.h:113:3: note: 'strtoul' declared here
|
strtoul(const char * __restrict, char ** __restrict, int);
|
^
|
2 warnings and 1 error generated.
|
Adding `#include <cstdlib>` to `storage/rocksdb/rdb_datadic.h` solves the issue on FreeBSD 11.0. Not sure if this should be enclosed in a #ifdef _FreeBSD_ block
{"report":{"fcp":869.2999999821186,"ttfb":232.40000000596046,"pageVisibility":"visible","entityId":63439,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"e6e2e235-11c3-495c-99aa-6df63721a6be","navigationType":0,"readyForUser":950.6999999880791,"redirectCount":0,"resourceLoadedEnd":628.9000000059605,"resourceLoadedStart":240.90000000596046,"resourceTiming":[{"duration":80.19999998807907,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":240.90000000596046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":240.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":321.09999999403954,"responseStart":0,"secureConnectionStart":0},{"duration":80.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":241.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":241.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":321.69999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":235.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":241.5,"connectEnd":323.7999999821186,"connectStart":323.7999999821186,"domainLookupEnd":323.7999999821186,"domainLookupStart":323.7999999821186,"fetchStart":241.5,"redirectEnd":0,"redirectStart":0,"requestStart":324.09999999403954,"responseEnd":477.09999999403954,"responseStart":338.40000000596046,"secureConnectionStart":323.7999999821186},{"duration":351.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":242.19999998807907,"connectEnd":242.19999998807907,"connectStart":242.19999998807907,"domainLookupEnd":242.19999998807907,"domainLookupStart":242.19999998807907,"fetchStart":242.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":325.7999999821186,"responseEnd":593.7999999821186,"responseStart":343.5,"secureConnectionStart":242.19999998807907},{"duration":99.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":242.40000000596046,"connectEnd":242.40000000596046,"connectStart":242.40000000596046,"domainLookupEnd":242.40000000596046,"domainLookupStart":242.40000000596046,"fetchStart":242.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":326.2999999821186,"responseEnd":342.09999999403954,"responseStart":340.90000000596046,"secureConnectionStart":242.40000000596046},{"duration":102.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":242.5,"connectEnd":242.5,"connectStart":242.5,"domainLookupEnd":242.5,"domainLookupStart":242.5,"fetchStart":242.5,"redirectEnd":0,"redirectStart":0,"requestStart":327,"responseEnd":345.09999999403954,"responseStart":342.40000000596046,"secureConnectionStart":242.5},{"duration":106.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":242.59999999403954,"connectEnd":242.59999999403954,"connectStart":242.59999999403954,"domainLookupEnd":242.59999999403954,"domainLookupStart":242.59999999403954,"fetchStart":242.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":327.90000000596046,"responseEnd":348.90000000596046,"responseStart":347.2999999821186,"secureConnectionStart":242.59999999403954},{"duration":84.7000000178814,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":242.7999999821186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":242.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":327.5,"responseStart":0,"secureConnectionStart":0},{"duration":109.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":243,"connectEnd":243,"connectStart":243,"domainLookupEnd":243,"domainLookupStart":243,"fetchStart":243,"redirectEnd":0,"redirectStart":0,"requestStart":331.59999999403954,"responseEnd":352.19999998807907,"responseStart":350.69999998807907,"secureConnectionStart":243},{"duration":85.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":243.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":243.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":329.09999999403954,"responseStart":0,"secureConnectionStart":0},{"duration":111,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":243.2999999821186,"connectEnd":243.2999999821186,"connectStart":243.2999999821186,"domainLookupEnd":243.2999999821186,"domainLookupStart":243.2999999821186,"fetchStart":243.2999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":332.19999998807907,"responseEnd":354.2999999821186,"responseStart":352.40000000596046,"secureConnectionStart":243.2999999821186},{"duration":383.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":245.40000000596046,"connectEnd":245.40000000596046,"connectStart":245.40000000596046,"domainLookupEnd":245.40000000596046,"domainLookupStart":245.40000000596046,"fetchStart":245.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":419.5,"responseEnd":628.9000000059605,"responseStart":624.0999999940395,"secureConnectionStart":245.40000000596046},{"duration":382.80000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":245.59999999403954,"connectEnd":245.59999999403954,"connectStart":245.59999999403954,"domainLookupEnd":245.59999999403954,"domainLookupStart":245.59999999403954,"fetchStart":245.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":514.5,"responseEnd":628.4000000059605,"responseStart":622.5,"secureConnectionStart":245.59999999403954},{"duration":185.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":603.1999999880791,"connectEnd":603.1999999880791,"connectStart":603.1999999880791,"domainLookupEnd":603.1999999880791,"domainLookupStart":603.1999999880791,"fetchStart":603.1999999880791,"redirectEnd":0,"redirectStart":0,"requestStart":753.1999999880791,"responseEnd":788.6999999880791,"responseStart":787.2999999821186,"secureConnectionStart":603.1999999880791}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":34,"responseStart":233,"responseEnd":244,"domLoading":236,"domInteractive":1009,"domContentLoadedEventStart":1009,"domContentLoadedEventEnd":1060,"domComplete":1725,"loadEventStart":1725,"loadEventEnd":1725,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":988.6999999880791},{"name":"bigPipe.sidebar-id.end","time":989.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":989.5999999940395},{"name":"bigPipe.activity-panel-pipe-id.end","time":991.0999999940395},{"name":"activityTabFullyLoaded","time":1074.9000000059605}],"measures":[],"correlationId":"6c1740da5aac17","effectiveType":"4g","downlink":9.8,"rtt":0,"serverDuration":108,"dbReadsTimeInMs":21,"dbConnsTimeInMs":30,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Critical
