[MDEV-13974] Build failure in rocksdb/rdb_datadic.cc - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.2.9
Fix Version/s: 10.2.10
Component/s: Platform FreeBSD, Storage Engine - RocksDB
Labels:
None
Environment:
FreeBSD 11.0-RELEASE-p6
Clang 3.8
cmake 3.9.2

Sprint:
10.2.10

Description

While building RocksDB I get a fatal compilation error

/usr/bin/c++ -DHAVE_CONFIG_H -DLZ4 -DMYSQL_DYNAMIC_PLUGIN -DOS_FREEBSD -DROCKSDB_JEMALLOC -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_PLATFORM_POSIX -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -DZLIB -DZSTD -Drocksdb_EXPORTS -Iinclude -Isql -Ipcre -Istorage/rocksdb/rocksdb -Istorage/rocksdb/rocksdb/include -isystem storage/rocksdb/rocksdb/third-party/gtest-1.7.0/fused-src -Istorage/rocksdb/rocksdb/util -I/usr/include -I/usr/local/include -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -DDBUG_OFF -fPIC -std=c++11 -MD -MT storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -MF storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o.d -o storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -c storage/rocksdb/rdb_datadic.cc

In file included from storage/rocksdb/rdb_datadic.cc:26:

In file included from storage/rocksdb/./rdb_datadic.h:35:

storage/rocksdb/./ha_rocksdb.h:1066:3: warning: declaration does not declare anything [-Wmissing-declarations]

  MY_ATTRIBUTE((__nonnull__, __warn_unused_result__));

storage/rocksdb/rdb_mariadb_port.h:18:27: note: expanded from macro 'MY_ATTRIBUTE'

#  define MY_ATTRIBUTE(A) __attribute__(A)

In file included from storage/rocksdb/rdb_datadic.cc:26:

In file included from storage/rocksdb/./rdb_datadic.h:36:

storage/rocksdb/./properties_collector.h:84:27: warning: 'AddUserKey' overrides a member function but is not marked 'override'

      [-Winconsistent-missing-override]

  virtual rocksdb::Status AddUserKey(const rocksdb::Slice &key,

storage/rocksdb/rocksdb/include/rocksdb/table_properties.h:89:18: note: overridden virtual function is here

  virtual Status AddUserKey(const Slice& key, const Slice& value,

storage/rocksdb/rdb_datadic.cc:371:19: error: no member named 'strtoul' in namespace 'std'; did you mean simply 'strtoul'?

  *ttl_duration = std::strtoull(ttl_duration_str.c_str(), nullptr, 0);

                  ^~~~~

/usr/include/stdlib.h:113:3: note: 'strtoul' declared here

         strtoul(const char * __restrict, char ** __restrict, int);

2 warnings and 1 error generated.

Adding `#include <cstdlib>` to `storage/rocksdb/rdb_datadic.h` solves the issue on FreeBSD 11.0. Not sure if this should be enclosed in a #ifdef _FreeBSD_ block

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

patch-storage_rocksdb_rdb__datadic.h
0.2 kB
2017-10-01 12:59

Issue Links

is duplicated by

MDEV-13945 RocksDB fails to build on macOS (llvm?)

Closed

relates to

MDEV-13945 RocksDB fails to build on macOS (llvm?)

Closed

Activity

Ascending order - Click to sort in descending order

Bernard Spil created issue - 2017-10-01 12:21

Bernard Spil made changes - 2017-10-01 12:59

Field	Original Value	New Value
Attachment		patch-storage_rocksdb_rdb__datadic.h [ 44272 ]

Bernard Spil added a comment - 2017-10-01 13:00

This built succesfully with all options enabled.
See build log here

Bernard Spil added a comment - 2017-10-01 13:00 This built succesfully with all options enabled. See build log here

Elena Stepanova made changes - 2017-10-01 13:07

Description

While building RocksDB I get a fatal compilation error
```
/usr/bin/c++ -DHAVE_CONFIG_H -DLZ4 -DMYSQL_DYNAMIC_PLUGIN -DOS_FREEBSD -DROCKSDB_JEMALLOC -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_PLATFORM_POSIX -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -DZLIB -DZSTD -Drocksdb_EXPORTS -Iinclude -Isql -Ipcre -Istorage/rocksdb/rocksdb -Istorage/rocksdb/rocksdb/include -isystem storage/rocksdb/rocksdb/third-party/gtest-1.7.0/fused-src -Istorage/rocksdb/rocksdb/util -I/usr/include -I/usr/local/include -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -DDBUG_OFF -fPIC -std=c++11 -MD -MT storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -MF storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o.d -o storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -c storage/rocksdb/rdb_datadic.cc
In file included from storage/rocksdb/rdb_datadic.cc:26:
In file included from storage/rocksdb/./rdb_datadic.h:35:
storage/rocksdb/./ha_rocksdb.h:1066:3: warning: declaration does not declare anything [-Wmissing-declarations]
  MY_ATTRIBUTE((__nonnull__, __warn_unused_result__));
  ^
storage/rocksdb/rdb_mariadb_port.h:18:27: note: expanded from macro 'MY_ATTRIBUTE'
# define MY_ATTRIBUTE(A) __attribute__(A)
                          ^
In file included from storage/rocksdb/rdb_datadic.cc:26:
In file included from storage/rocksdb/./rdb_datadic.h:36:
storage/rocksdb/./properties_collector.h:84:27: warning: 'AddUserKey' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  virtual rocksdb::Status AddUserKey(const rocksdb::Slice &key,
                          ^
storage/rocksdb/rocksdb/include/rocksdb/table_properties.h:89:18: note: overridden virtual function is here
  virtual Status AddUserKey(const Slice& key, const Slice& value,
                 ^
storage/rocksdb/rdb_datadic.cc:371:19: error: no member named 'strtoul' in namespace 'std'; did you mean simply 'strtoul'?
  *ttl_duration = std::strtoull(ttl_duration_str.c_str(), nullptr, 0);
                  ^~~~~
/usr/include/stdlib.h:113:3: note: 'strtoul' declared here
         strtoul(const char * __restrict, char ** __restrict, int);
         ^
2 warnings and 1 error generated.
```

Adding `#include <cstdlib>` to `storage/rocksdb/rdb_datadic.h` solves the issue on FreeBSD 11.0. Not sure if this should be enclosed in a #ifdef __FreeBSD__ block

While building RocksDB I get a fatal compilation error

{noformat}
/usr/bin/c++ -DHAVE_CONFIG_H -DLZ4 -DMYSQL_DYNAMIC_PLUGIN -DOS_FREEBSD -DROCKSDB_JEMALLOC -DROCKSDB_LIB_IO_POSIX -DROCKSDB_MALLOC_USABLE_SIZE -DROCKSDB_PLATFORM_POSIX -DROCKSDB_SUPPORT_THREAD_LOCAL -DSNAPPY -DZLIB -DZSTD -Drocksdb_EXPORTS -Iinclude -Isql -Ipcre -Istorage/rocksdb/rocksdb -Istorage/rocksdb/rocksdb/include -isystem storage/rocksdb/rocksdb/third-party/gtest-1.7.0/fused-src -Istorage/rocksdb/rocksdb/util -I/usr/include -I/usr/local/include -O2 -pipe -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -DDBUG_OFF -fPIC -std=c++11 -MD -MT storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -MF storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o.d -o storage/rocksdb/CMakeFiles/rocksdb.dir/rdb_datadic.cc.o -c storage/rocksdb/rdb_datadic.cc
{noformat}
{noformat}
In file included from storage/rocksdb/rdb_datadic.cc:26:
In file included from storage/rocksdb/./rdb_datadic.h:35:
storage/rocksdb/./ha_rocksdb.h:1066:3: warning: declaration does not declare anything [-Wmissing-declarations]
  MY_ATTRIBUTE((__nonnull__, __warn_unused_result__));
  ^
storage/rocksdb/rdb_mariadb_port.h:18:27: note: expanded from macro 'MY_ATTRIBUTE'
# define MY_ATTRIBUTE(A) __attribute__(A)
                          ^
In file included from storage/rocksdb/rdb_datadic.cc:26:
In file included from storage/rocksdb/./rdb_datadic.h:36:
storage/rocksdb/./properties_collector.h:84:27: warning: 'AddUserKey' overrides a member function but is not marked 'override'
      [-Winconsistent-missing-override]
  virtual rocksdb::Status AddUserKey(const rocksdb::Slice &key,
                          ^
storage/rocksdb/rocksdb/include/rocksdb/table_properties.h:89:18: note: overridden virtual function is here
  virtual Status AddUserKey(const Slice& key, const Slice& value,
                 ^
storage/rocksdb/rdb_datadic.cc:371:19: error: no member named 'strtoul' in namespace 'std'; did you mean simply 'strtoul'?
  *ttl_duration = std::strtoull(ttl_duration_str.c_str(), nullptr, 0);
                  ^~~~~
/usr/include/stdlib.h:113:3: note: 'strtoul' declared here
         strtoul(const char * __restrict, char ** __restrict, int);
         ^
2 warnings and 1 error generated.
{noformat}

Adding `#include <cstdlib>` to `storage/rocksdb/rdb_datadic.h` solves the issue on FreeBSD 11.0. Not sure if this should be enclosed in a #ifdef __FreeBSD__ block

Elena Stepanova added a comment - 2017-10-01 13:08

Same failure was reported in ~~MDEV-13945~~, so it's not limited to MacOS.

Elena Stepanova added a comment - 2017-10-01 13:08 Same failure was reported in MDEV-13945 , so it's not limited to MacOS.

Elena Stepanova made changes - 2017-10-01 13:08

Link

This issue relates to ~~MDEV-13945~~ [ ~~MDEV-13945~~ ]

Elena Stepanova made changes - 2017-10-01 13:08

Fix Version/s		10.2 [ 14601 ]
Assignee		Varun Gupta [ varun ]

Elena Stepanova made changes - 2017-10-01 13:08

Component/s

Platform FreeBSD [ 10139 ]

Sergei Golubchik made changes - 2017-10-03 21:37

Priority

Major [ 3 ]

Critical [ 2 ]

Sergei Golubchik made changes - 2017-10-04 14:45

Sprint

10.2.10 [ 183 ]

Varun Gupta (Inactive) made changes - 2017-10-05 16:53

Status

Open [ 1 ]

In Progress [ 3 ]

Sergei Golubchik made changes - 2017-10-10 18:17

Assignee

Varun Gupta [ varun ]

Sergei Golubchik [ serg ]

Sergei Golubchik made changes - 2017-10-10 18:17

Status

In Progress [ 3 ]

In Review [ 10002 ]

Sergei Golubchik added a comment - 2017-10-10 18:17

ok to push

Sergei Golubchik added a comment - 2017-10-10 18:17 ok to push

Sergei Golubchik made changes - 2017-10-10 18:17

Assignee	Sergei Golubchik [ serg ]	Varun Gupta [ varun ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Varun Gupta (Inactive) made changes - 2017-10-11 16:21

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Varun Gupta (Inactive) made changes - 2017-10-11 16:22

Fix Version/s		10.2.10 [ 22615 ]
Fix Version/s	10.2 [ 14601 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Varun Gupta (Inactive) made changes - 2017-10-11 16:25

Link

This issue is duplicated by ~~MDEV-13945~~ [ ~~MDEV-13945~~ ]

Sergei Golubchik made changes - 2021-12-06 21:45

Workflow

MariaDB v3 [ 82878 ]

MariaDB v4 [ 152927 ]

People

Assignee:: Varun Gupta (Inactive)

Reporter:: Bernard Spil

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2017-10-01 12:21

Updated:: 2017-10-11 16:25

Resolved:: 2017-10-11 16:22

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration