Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13440

mysql_install_db fails with hard-coded langdir

Details

    • 5.5.58

    Description

      When the server is installs the share files to a non-default location like /usr/share/mariadb, the mysql_install_db scripts will fail to locate the language files and fill_help_tables.sql file when using the --basedir option.

      How to repeat:
      cmake -DINSTALL_MYSQLSHAREDIR=share/mariadb .

      The attached patch will prioritize this setting but keep the old locations for compatibility sake.

      Attachments

        Issue Links

          Activity

            grknight Brian Evans created issue -
            grknight Brian Evans made changes -
            Field Original Value New Value
            Description When the server is installs the share files to a non-default location like /usr/share/mariadb, the mysql_install_db scripts will fail to locate the language files and fill_help_tables.sql file.

            How to repeat:
            cmake -DINSTALL_MYSQLSHAREDIR=share/mariadb .

            The attached patch will prioritize this setting but keep the old locations for compatibility sake.
            When the server is installs the share files to a non-default location like /usr/share/mariadb, the mysql_install_db scripts will fail to locate the language files and fill_help_tables.sql file when using the --basedir option.

            How to repeat:
            cmake -DINSTALL_MYSQLSHAREDIR=share/mariadb .

            The attached patch will prioritize this setting but keep the old locations for compatibility sake.
            serg Sergei Golubchik made changes -
            Affects Version/s 5.5 [ 15800 ]
            Affects Version/s 10.0 [ 16000 ]
            Affects Version/s 10.1 [ 16100 ]
            Affects Version/s 10.2 [ 14601 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5 [ 15800 ]
            Fix Version/s 10.0 [ 16000 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.2 [ 14601 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Sprint 5.5.58 [ 197 ]
            serg Sergei Golubchik made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            serg Sergei Golubchik made changes -
            Comment [ There's a problem with your patch, but it only applies to our binary tarball packages, you are not affected.

            {{@pkgdatadir@}} is an absolute path:
            {code:perl|linenumbers|title=scripts/CMakeLists.txt|firstline=224}
            SET(prefix "${CMAKE_INSTALL_PREFIX}")
            SET(sysconfdir "${prefix}")
            SET(bindir "${prefix}/${INSTALL_BINDIR}")
            SET(libexecdir "${prefix}/${INSTALL_SBINDIR}")
            SET(scriptdir "${prefix}/${INSTALL_BINDIR}")
            SET(datadir "${prefix}/${INSTALL_MYSQLSHAREDIR}")
            SET(pkgdatadir "${prefix}/${INSTALL_MYSQLSHAREDIR}")
            {code}
            So, in binary tarballs patched {{mysql_install_db}} will always prefer system-wide {{/usr/share/mysql}} if it exists.

            I'll try to come up with a fix that works both for distributions and for binary tarballs. ]
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5.58 [ 22540 ]
            Fix Version/s 10.0.33 [ 22552 ]
            Fix Version/s 10.1.29 [ 22636 ]
            Fix Version/s 10.2.10 [ 22615 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 5.5 [ 15800 ]
            Fix Version/s 10.0 [ 16000 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            svoj Sergey Vojtovich made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 81900 ] MariaDB v4 [ 152562 ]

            People

              serg Sergei Golubchik
              grknight Brian Evans
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.