Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-11616

Build time macro @INSTALL_MYSQLSHAREDIR@ not honored in mysql_install_db

Details

    • 10.1.30

    Description

      Build time macro @INSTALL_MYSQLSHAREDIR@ is not honored in mysql_install_db (both, bash and perl variants). The language files can be installed into arbitrary directory when we specify INSTALL_MYSQLSHAREDIR macro in cmake call, but mysql_install_db scripts still look into $basedir/share/mysql directories.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. MDEV-13440 mysql_install_db fails with hard-coded langdir

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            hhorak Honza Horak added a comment -

            Proposed patch that we use in Fedora/RHEL attached.

            hhorak Honza Horak added a comment - Proposed patch that we use in Fedora/RHEL attached.
            serg Sergei Golubchik added a comment -

            Probably, already fixed in MDEV-13440

            serg Sergei Golubchik added a comment - Probably, already fixed in MDEV-13440
            svoj Sergey Vojtovich added a comment -

            I confirm this should've been fixed by https://github.com/MariaDB/server/commit/93144b9e92d3d4fee3247895c1e06e8e7cfedcaa

            $ cmake -DINSTALL_MYSQLSHAREDIR=/somefunloc
            		 
            ...
            		 
            $ grep somefunloc scripts/mysql_install_db
            		 
              langdir=`find_in_dirs --dir errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english`
            		 
                cannot_find_file errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english
            		 
              srcpkgdatadir=`find_in_dirs --dir fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql`
            		 
                cannot_find_file fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql
            		 
              srcpkgdatadir=".//somefunloc"
            		 
              buildpkgdatadir=".//somefunloc"

            svoj Sergey Vojtovich added a comment - I confirm this should've been fixed by https://github.com/MariaDB/server/commit/93144b9e92d3d4fee3247895c1e06e8e7cfedcaa $ cmake -DINSTALL_MYSQLSHAREDIR=/somefunloc ... $ grep somefunloc scripts/mysql_install_db langdir=`find_in_dirs --dir errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english` cannot_find_file errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english srcpkgdatadir=`find_in_dirs --dir fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql` cannot_find_file fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql srcpkgdatadir=".//somefunloc" buildpkgdatadir=".//somefunloc"

            People

              svoj Sergey Vojtovich
              hhorak Honza Horak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.