[MDEV-11616] Build time macro @INSTALL_MYSQLSHAREDIR@ not honored in mysql_install_db Created: 2016-12-20  Updated: 2017-12-18  Resolved: 2017-12-18

Status: Closed
Project: MariaDB Server
Component/s: Scripts & Clients
Affects Version/s: 10.1, 10.1.20
Fix Version/s: 5.5.58, 10.0.33, 10.1.29, 10.2.10

Type: Bug Priority: Major
Reporter: Honza Horak Assignee: Sergey Vojtovich
Resolution: Duplicate Votes: 0
Labels: contribution
Environment:

Linux, RHEL-7, RPM

Attachments: File mariadb-install-db-sharedir.patch    
Issue Links:
Duplicate
duplicates MDEV-13440 mysql_install_db fails with hard-code... Closed
Sprint: 10.1.30

 Description   

Build time macro @INSTALL_MYSQLSHAREDIR@ is not honored in mysql_install_db (both, bash and perl variants). The language files can be installed into arbitrary directory when we specify INSTALL_MYSQLSHAREDIR macro in cmake call, but mysql_install_db scripts still look into $basedir/share/mysql directories.

 Comments   
Comment by Honza Horak [ 2016-12-20 ]

Proposed patch that we use in Fedora/RHEL attached.

Comment by Sergei Golubchik [ 2017-12-12 ]

Probably, already fixed in MDEV-13440

Comment by Sergey Vojtovich [ 2017-12-18 ]

I confirm this should've been fixed by https://github.com/MariaDB/server/commit/93144b9e92d3d4fee3247895c1e06e8e7cfedcaa

$ cmake -DINSTALL_MYSQLSHAREDIR=/somefunloc
 
...
 
$ grep somefunloc scripts/mysql_install_db
 
  langdir=`find_in_dirs --dir errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english`
 
    cannot_find_file errmsg.sys $basedir//somefunloc/english $basedir/share/english $basedir/share/mysql/english
 
  srcpkgdatadir=`find_in_dirs --dir fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql`
 
    cannot_find_file fill_help_tables.sql $basedir//somefunloc $basedir/share $basedir/share/mysql
 
  srcpkgdatadir=".//somefunloc"
 
  buildpkgdatadir=".//somefunloc"

Generated at Thu Feb 08 07:51:20 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.